Skip to content

investigate flaky test-domain-abort-on-uncaught #11814

Description

@Trott
  • Version: v8.0.0-pre
  • Platform: armv7-ubuntu1404
  • Subsystem: domain

https://ci.nodejs.org/job/node-test-commit-arm/8238/nodes=armv7-ubuntu1404/console

not ok 295 parallel/test-domain-abort-on-uncaught
  ---
  duration_ms: 1.834
  severity: fail
  stack: |-
    
    assert.js:81
      throw new assert.AssertionError({
      ^
    AssertionError: Test at index 7 should have exited with exit code 0 but instead exited with code 134 and signal null
        at ChildProcess.onExit (/home/iojs/build/workspace/node-test-commit-arm/nodes/armv7-ubuntu1404/test/parallel/test-domain-abort-on-uncaught.js:251:14)
        at emitTwo (events.js:127:13)
        at ChildProcess.emit (events.js:215:7)
        at Process.ChildProcess._handle.onexit (internal/child_process.js:208:12)

Activity

added
armIssues and PRs related to the ARM architecture.
domainIssues and PRs related to the domain subsystem.
testIssues and PRs related to Node.js core tests and test infrastructure.
on Mar 12, 2017

Trott commented on Mar 12, 2017

@Trott
MemberAuthor

This test is flaky under load. This can be seen by running it with a command like this:

tools/test.py -j 32 --repeat=32 test/parallel/test-domain-abort-on-uncaught.js

(If 32 isn't enough to cause problems on your setup, try 64 or higher.)

There are at least three solutions possible here:

  • move the test to sequential
  • break the test up into as many as 13 separate test files so that each one is launching one additional node process rather than one test launching 13 of them in parallel
  • rewrite the test to run the 13 processes sequentially rather than in parallel

I'll open a PR to move to sequential. The second or third option above can be a good first contribution for someone.

self-assigned this
on Mar 12, 2017

Trott commented on Mar 12, 2017

@Trott
MemberAuthor

Fix in #11817

gibfahn commented on Mar 13, 2017

@gibfahn
Member
  • break the test up into as many as 13 separate test files so that each one is launching one additional node process rather than one test launching 13 of them in parallel
  • rewrite the test to run the 13 processes sequentially rather than in parallel

I'll open a PR to move to sequential. The second or third option above can be a good first contribution for someone.

I'll open a new issue for this (as I assume this one will be closed by #11817).

EDIT: Issue raised: #11826

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

armIssues and PRs related to the ARM architecture.domainIssues and PRs related to the domain subsystem.testIssues and PRs related to Node.js core tests and test infrastructure.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions