Skip to content

AIX CI failure: pseudo-tty/test-stderr-stdout-handle-sigwinch #11541

Description

@gibfahn
  • Version: master
  • Platform: AIX
  • Subsystem: test

pseudo-tty/test-stderr-stdout-handle-sigwinch failed the last two CI runs on the v4.x-staging branch (started by node-daily-v4.x-staging.

https://ci.nodejs.org/job/node-test-commit-aix/nodes=aix61-ppc64/4025/

Failed Build: https://ci.nodejs.org/job/node-test-commit/8092/
Failed Platform: https://ci.nodejs.org/job/node-test-commit-aix/4025
Actual Job: https://ci.nodejs.org/job/node-test-commit-aix/nodes=aix61-ppc64/4025/

not ok 1097 pseudo-tty/test-stderr-stdout-handle-sigwinch
  ---
  duration_ms: 0.211
  severity: fail
  stack: |-
  ...

cc/ @mhdawson @nodejs/platform-aix

Activity

  1. added
    aixIssues and PRs related to the AIX platform.
    testIssues and PRs related to Node.js core tests and test infrastructure.
    on Feb 24, 2017
  2. Fishrock123 commented on Feb 24, 2017

    @Fishrock123
    Contributor

    I still think ptys just don't work right on AIX

  3. gibfahn commented on Feb 24, 2017

    @gibfahn
    MemberAuthor

    Possibly related pseudo-tty issues:

    cc/ @gireeshpunathil who has been looking at these other tests

  4. Fishrock123 commented on Feb 24, 2017

    @Fishrock123
    Contributor

    either that or TTYs don't work right on AIX

    maybe just ignore them altogether for AIX? idk

  5. mhdawson commented on Feb 24, 2017

    @mhdawson
    Member

    Is this a newly backported test ? Just wondering why it would be failing consistently now versus before (if in fact 2 in a row is consistent :))

  6. gibfahn commented on Feb 25, 2017

    @gibfahn
    MemberAuthor
  7. gireeshpunathil commented on Feb 27, 2017

    @gireeshpunathil
    Member

    @Fishrock123 - other than the intermittent hang issue reported in python bug 29545 and the race condition as described in #9728, I don't see any functional issue for TTYs in AIX.

    I am debugging this SIGWINCH issue to see what caused the issue.

  8. gireeshpunathil commented on Feb 27, 2017

    @gireeshpunathil
    Member

    I guess the idea of the test case is to make sure the _refreshSize() of the standard streams gets called when SIGWINCH is issued on the process. This is indeed happening, consistently. What is missing again, is the race condition between the child write and the parent read.

    I am in the process of experimenting by customizing the child spawn logic in the python parent to see if we can sync up the write-read logic.

  9. mhdawson commented on Feb 27, 2017

    @mhdawson
    Member

    Do this test fail every time on 4.x ?

  10. gireeshpunathil commented on Feb 27, 2017

    @gireeshpunathil
    Member

    @mhdawson - yes, it is pretty consistent in v4.x The test passes in master, though there is a slight change in the test code (even with nullifying the change, I see the master passing).

    Whereas, if I add a small delay in the v4.x case, it is consistently passing, supporting my previous update - that is, there is no new issue here, other than the race condition.

    I will come up with a PR to exclude this for v4.x and work on addressing the race condition

  11. gireeshpunathil commented on Feb 28, 2017

    @gireeshpunathil
    Member

    For the time exclude request raised through PR #11602

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    aixIssues and PRs related to the AIX platform.testIssues and PRs related to Node.js core tests and test infrastructure.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions