Skip to content

Tests that rely upon common.spawnCat() faill in Windows with Unicode shell codepage #11470

Closed
Closed
Tests that rely upon common.spawnCat() faill in Windows with Unicode shell codepage#11470
Labels
testIssues and PRs related to Node.js core tests and test infrastructure.windowsIssues and PRs related to the Windows platform.

Description

@vsemozhetbyt
vsemozhetbyt
opened on Feb 20, 2017
  • Version: possibly all
  • Platform: Windows 7 x64
  • Subsystem: test, child_process

For context see #11469

test/parallel/test-child-process-stdio-inherit.js calls common.spawnCat() that calls more for Windows. more fails with Unicode shell codepage.

To check test/parallel/test-child-process-stdio-inherit.js pass:

chcp 65001 && node test\parallel\test-child-process-stdio-inherit.js
Active code page: 65001
Not enough memory.
... AssertionError: '' === 'asdfasdf' ...

chcp 1252 && node test\parallel\test-child-process-stdio-inherit.js
Active code page: 1252
[pass]

It seems currently this is the only test that uses common.spawnCat().

Activity

  1. mscdex
    added
    testIssues and PRs related to Node.js core tests and test infrastructure.
    windowsIssues and PRs related to the Windows platform.
    on Feb 21, 2017

  2. joaocgreis commented on Feb 21, 2017

    @joaocgreis
    joaocgreis
    on Feb 21, 2017
    Member

    Can't this be addressed as a duplicate of #11469 ? If I understand correctly, this is for spawnCat while #11469 is for more directly, but given that spawnCat uses more, the underlying issue is the same, right?

  3. vsemozhetbyt commented on Feb 21, 2017

    @vsemozhetbyt
    vsemozhetbyt
    on Feb 21, 2017
    ContributorAuthor

    @joaocgreis Yeah, I just was not sure if I should combine the issue with the lib and the issue with individual tests. If anybody finds a universal solution, please, close the both issues. Or feel free to close any of them as a duplicate in advance.

  4. joaocgreis commented on Feb 22, 2017

    @joaocgreis
    joaocgreis
    on Feb 22, 2017
    Member

    Closing as a duplicate of #11469 .

    Thanks @vsemozhetbyt ! If this was an issue in /lib then it would be an issue for users and would have to be addressed differently, but /test/common.js is only used by the tests, so I think this is essentially the same problem.

  5. joaocgreis
    closed this as completedon Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    testIssues and PRs related to Node.js core tests and test infrastructure.windowsIssues and PRs related to the Windows platform.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions