Repository navigation
meta, url: track WHATWG URL implementation in GitHub project #10625
Description
Activity
- addedmetaIssues and PRs related to the general management of the project.Issues and PRs related to the general management of the project.urlIssues and PRs related to the legacy built-in url module.Issues and PRs related to the legacy built-in url module.
on Jan 5, 2017 Go for it!
I've opened the project and made a few columns. Trying to move issues/PRs into it. https://github.com/nodejs/node/projects/5
Let me know if you think there is a better way to layout the columns.
What if we just add a new label and use that, like
url-whatwgor something?Reacted by James M Snell@mscdex Yes that would be very helpful too, but I think columns would make it clearer to see where we are at.
Looks like GitHub doesn't allow you to make one card out of issues + PRs :/. This makes it harder to see the progress of works to be done.
EDIT: I rearrange the columns so that PRs follow relevant issues.
I have added a new label
whatwg-url(changed the word order from the one suggested by @mscdex , because it is how it's used in existing tests/benchmarks). If no more concerns arise I will start to label PRs/issues (not sure if theurllabel on them need to go?).The reason I suggested
url-whatwgin that order was that that way both labels (urlandurl-whatwg) will show up together in the list of labels and it might be easier for management purposes to "group" them together like this?Most PRs use "WHATWG URL" in their names/commit logs and
whatwg-urlin their filenames. Could be a source of typos if the bot grabs the label from theaffected subsytemssection(does it?).The nodejs github bot does not label issues, it only labels pull requests (based on files changed, base branches, etc. -- never based on any text in the original PR or commit messages).
OK if the bot doesn't rely on those text then it should be fine. I changed the label to
url-whatwg. If it does cause typos we can always change it back I guess. Any more concerns?- addedwhatwg-urlIssues and PRs related to the WHATWG URL implementation.Issues and PRs related to the WHATWG URL implementation.
on Jan 5, 2017 I've labeled the PRs and issues marked in the Github project and submitted a PR for the bot to use this new label.
- removedurlIssues and PRs related to the legacy built-in url module.Issues and PRs related to the legacy built-in url module.
on Jan 5, 2017 Maybe it’s a good idea to create a @nodejs/url github team with the four of you as initial members?
Reacted by James M Snell, Gibson Fahnestock and Joyee Cheung@addaleax good idea, done!
May I suggest a "waiting on the spec" column of some sort?
@domenic Seems it's done (No idea who, but thanks anyway)
I updated the columns last night and bit a bit of reorg/cleanup.
The WHATWG URL spec is still moving and we are just starting to document this new API (#10620). It might be helpful to have a central place tracking the issues(especially the spec changes), doc/url/benchmark/test PRs, and it can help differentiate the WHATWG URL work from the old url module work(all under the
urllabel at the moment) and prevent concurrent PR conflicts.A meta issue tracking all these can be good enough but I think a GitHub project would be better. I am not very familiar with the GitHub project feature just yet but will be happy to open one if people think it's useful.
cc/ @jasnell @targos @TimothyGu