Skip to content

meta, url: track WHATWG URL implementation in GitHub project #10625

Description

@joyeecheung
  • Version: all
  • Platform: all
  • Subsystem: url

The WHATWG URL spec is still moving and we are just starting to document this new API (#10620). It might be helpful to have a central place tracking the issues(especially the spec changes), doc/url/benchmark/test PRs, and it can help differentiate the WHATWG URL work from the old url module work(all under the url label at the moment) and prevent concurrent PR conflicts.

A meta issue tracking all these can be good enough but I think a GitHub project would be better. I am not very familiar with the GitHub project feature just yet but will be happy to open one if people think it's useful.

cc/ @jasnell @targos @TimothyGu

Activity

  1. added
    metaIssues and PRs related to the general management of the project.
    urlIssues and PRs related to the legacy built-in url module.
    on Jan 5, 2017
  2. jasnell commented on Jan 5, 2017

    @jasnell
    Member

    Go for it!

  3. joyeecheung commented on Jan 5, 2017

    @joyeecheung
    MemberAuthor

    I've opened the project and made a few columns. Trying to move issues/PRs into it. https://github.com/nodejs/node/projects/5

    Let me know if you think there is a better way to layout the columns.

  4. mscdex commented on Jan 5, 2017

    @mscdex
    Contributor

    What if we just add a new label and use that, like url-whatwg or something?

  5. joyeecheung commented on Jan 5, 2017

    @joyeecheung
    MemberAuthor

    @mscdex Yes that would be very helpful too, but I think columns would make it clearer to see where we are at.

  6. joyeecheung commented on Jan 5, 2017

    @joyeecheung
    MemberAuthor

    Looks like GitHub doesn't allow you to make one card out of issues + PRs :/. This makes it harder to see the progress of works to be done.

    EDIT: I rearrange the columns so that PRs follow relevant issues.

  7. joyeecheung commented on Jan 5, 2017

    @joyeecheung
    MemberAuthor

    I have added a new label whatwg-url(changed the word order from the one suggested by @mscdex , because it is how it's used in existing tests/benchmarks). If no more concerns arise I will start to label PRs/issues (not sure if the url label on them need to go?).

  8. mscdex commented on Jan 5, 2017

    @mscdex
    Contributor

    The reason I suggested url-whatwg in that order was that that way both labels (url and url-whatwg) will show up together in the list of labels and it might be easier for management purposes to "group" them together like this?

  9. joyeecheung commented on Jan 5, 2017

    @joyeecheung
    MemberAuthor

    Most PRs use "WHATWG URL" in their names/commit logs and whatwg-url in their filenames. Could be a source of typos if the bot grabs the label from the affected subsytems section(does it?).

  10. mscdex commented on Jan 5, 2017

    @mscdex
    Contributor

    The nodejs github bot does not label issues, it only labels pull requests (based on files changed, base branches, etc. -- never based on any text in the original PR or commit messages).

  11. joyeecheung commented on Jan 5, 2017

    @joyeecheung
    MemberAuthor

    OK if the bot doesn't rely on those text then it should be fine. I changed the label to url-whatwg. If it does cause typos we can always change it back I guess. Any more concerns?

  12. added
    whatwg-urlIssues and PRs related to the WHATWG URL implementation.
    on Jan 5, 2017
  13. joyeecheung commented on Jan 5, 2017

    @joyeecheung
    MemberAuthor

    I've labeled the PRs and issues marked in the Github project and submitted a PR for the bot to use this new label.

  14. removed
    urlIssues and PRs related to the legacy built-in url module.
    on Jan 5, 2017
  15. addaleax commented on Jan 5, 2017

    @addaleax
    Member

    cc/ @jasnell @targos @TimothyGu

    Maybe it’s a good idea to create a @nodejs/url github team with the four of you as initial members?

  16. targos commented on Jan 5, 2017

    @targos
    Member

    @addaleax good idea, done!

  17. domenic commented on Jan 12, 2017

    @domenic
    Contributor

    May I suggest a "waiting on the spec" column of some sort?

  18. joyeecheung commented on Jan 12, 2017

    @joyeecheung
    MemberAuthor

    @domenic Seems it's done (No idea who, but thanks anyway)

  19. jasnell commented on Jan 12, 2017

    @jasnell
    Member

    I updated the columns last night and bit a bit of reorg/cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    metaIssues and PRs related to the general management of the project.whatwg-urlIssues and PRs related to the WHATWG URL implementation.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions