Skip to content

Remove removed-from-spec URL.domainToASCII/domainToUnicode #10375

Closed
Closed
Remove removed-from-spec URL.domainToASCII/domainToUnicode#10375
Labels
urlIssues and PRs related to the legacy built-in url module.whatwg-urlIssues and PRs related to the WHATWG URL implementation.

Description

@domenic
domenic
opened on Dec 21, 2016

These static methods were removed from the URL Standard in whatwg/url@2bd0f59 since they were not implemented anywhere. They should have been marked experimental and at-risk in the spec, but unfortunately were not at the time, so Node implemented them. Fortunately Node's URL implementation is experimental so these should be removable without issues.

Activity

  1. addaleax
    added
    urlIssues and PRs related to the legacy built-in url module.
    on Dec 21, 2016

  2. jasnell commented on Dec 21, 2016

    @jasnell
    jasnell
    on Dec 21, 2016
    Member

    For now I would move these to hang off require('url') rather than off require('url').URL. There's value in keeping them around in Node.js given that they are so much faster than the pure javascript punycode module.

  3. targos commented on Jan 2, 2017

    @targos
    targos
    on Jan 2, 2017
    Member

    Moved to require('url') in abc1633.

  4. targos
    closed this as completedon Jan 2, 2017
  5. joyeecheung
    added
    whatwg-urlIssues and PRs related to the WHATWG URL implementation.
    on Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    urlIssues and PRs related to the legacy built-in url module.whatwg-urlIssues and PRs related to the WHATWG URL implementation.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions