Skip to content

Remove nonstandard URL.originFor #10374

Closed
Closed
Remove nonstandard URL.originFor#10374
Labels
urlIssues and PRs related to the legacy built-in url module.whatwg-urlIssues and PRs related to the WHATWG URL implementation.

Description

@domenic
domenic
opened on Dec 21, 2016

Apparently the new WHATWG URL API includes a nonstandard static method originFor. Its presence encourages writing code that is not interoperable between Node.js and browsers. It should be removed.

Activity

  1. addaleax
    added
    urlIssues and PRs related to the legacy built-in url module.
    on Dec 21, 2016

  2. jasnell commented on Dec 21, 2016

    @jasnell
    jasnell
    on Dec 21, 2016
    Member

    Not really removed so much as moved... it should hang off the require('url') module rather than require('url').URL

  3. domenic commented on Dec 21, 2016

    @domenic
    domenic
    on Dec 21, 2016
    ContributorAuthor

    Hmm, what is the benefit of that over new URL(...).origin?

  4. targos commented on Jan 2, 2017

    @targos
    targos
    on Jan 2, 2017
    Member

    Moved to require('url') in abc1633.

  5. targos
    closed this as completedon Jan 2, 2017
  6. joyeecheung
    added
    whatwg-urlIssues and PRs related to the WHATWG URL implementation.
    on Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    urlIssues and PRs related to the legacy built-in url module.whatwg-urlIssues and PRs related to the WHATWG URL implementation.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions