Skip to content

spawnSync tests failed on arm64 in ci job #1035

Description

@shigeki

spawnSync tests on arm64 in ci job were failed with TIMEOUT in
https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/nodes=iojs-armv8-ubuntu1404/234/console
and related tests using spawnSync were also failed as discussed in #1028 .

CC: @bnoordhuis

Activity

added
child_processIssues and PRs related to the child_process subsystem.
on Mar 3, 2015

jbergstroem commented on Mar 3, 2015

@jbergstroem
Member

Suggesting we introduce a helper in common.js that allows tests to skip if crypto isn't available?

shigeki commented on Mar 3, 2015

@shigeki
ContributorAuthor

jbergstroem commented on Mar 3, 2015

@jbergstroem
Member

Oh, didn't know that. Well, lets expand that then?

Edit: how about https://gist.github.com/jbergstroem/eeec8cef7a37294ba580? If the entire file is affected, we just check and process.exit() - similar to what's found in test-crypto.js.

brendanashworth commented on Mar 3, 2015

@brendanashworth
Contributor

@jbergstroem +1 for that, keeping the code DRY, but lets use a Getter for that so v8 doesn't have to reload the crypto module for each test regardless of whether it is used (800 times).

jbergstroem commented on Mar 3, 2015

@jbergstroem
Member

Ok, I'll do a PR.

shigeki commented on Mar 3, 2015

@shigeki
ContributorAuthor

Some tls tests have another kind of checks as https://github.com/iojs/io.js/blob/v1.x/test/parallel/test-tls-0-dns-altname.js#L1-L4 . I'm not sure which one is better but the current tests which depends on configure library should be reconsidered.

jbergstroem commented on Mar 3, 2015

@jbergstroem
Member

Regardless check, we should at least mark all tests as skippable. I'll start by doing a common check and go through all tests looking for tls/crypto/anything else I can find.

shigeki commented on Mar 25, 2015

@shigeki
ContributorAuthor

The issue of the timeout errors in spawnSync tests on armv8 seems to be caused by libuv and resolved by shigeki@c60d978. The CI of https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/nodes=iojs-armv8-ubuntu1404/372/ showed only one error regarding a debug port.

@rvagg Can I make libuv tests on armv8 with Jenkins?

shigeki commented on Apr 8, 2015

@shigeki
ContributorAuthor

Fixed by #1365 . Thanks @bnoordhuis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    child_processIssues and PRs related to the child_process subsystem.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions