Repository navigation
feat: support gyp with ninja - #2171
codebytere wants to merge 1 commit into
Conversation
d842d73 to
6d5ee8f
Compare
|
Does this work on Windows too? There's a few places where I'm fine with this all except for the download-ninja bit which makes me hesitant. It's checking if it's installed, but only if it's installed in the exact place where it will place it after downloading. What I wonder is - if you're using |
|
This would be useful on Windows, where msbuild currently fails when node-gyp is run in parallel. #3095 |
Description of change
This is a draft feedback request for adding baseline ninja support to
node-gyp.gypalready supportsninjaout of the box, so this installs ninja to a user's computer if it doesn't exist, and then allows for its use when the--ninjaflag is passed.This is motivated by work i did recently to support Swift compilation using
node-gyp: https://github.com/codebytere/node-mac-swift-addon and this commit.The whole patchset is likely untenable to upstream, so I'd like just to seek feedback on this portion at this point!
Tests and documentation would come after initial feedback on the potential path forward here.
cc @rvagg
Checklist
npm install && npm testpasses