Skip to content

9.4.0 should've been semver-major #2873

Closed

Description

@blattersturm

We're stuck running on Node.js 12.x due to node-ffi-napi being nondeterministically broken on any release above 14.x.

In this project, we install node-gyp@9, but since 9.4.0 bumped to make-fetch-happen@11 (via 02480f6) which has a semver-major change that propagates downward, installing fails as such:

error make-fetch-happen@11.1.1: The engine "node" is incompatible with this module. Expected version "^14.17.0 || ^16.13.0 || >=18.0.0". Got "12.22.12"
error Found incompatible module.

From the make-fetch-happen changelog:

⚠️ BREAKING CHANGES

  • make-fetch-happen is now compatible with the following semver range for node: ^14.17.0 || ^16.13.0 || >=18.0.0

Another failing in this amazing 'semver' system? Probably.

Activity

  1. cclauss commented on Jun 15, 2023

    @cclauss
    Contributor

    Have you reviewed and approved #2849 ?

  2. blattersturm commented on Jun 15, 2023

    @blattersturm
    Author

    Ah, I didn't see that one. Whoops, that's on me for not checking beforehand - ouch though at how a release shipped without solving this. :(

  3. lukekarrys commented on Oct 27, 2023

    @lukekarrys
    Member

    v9.4.1 has been released which reverts the dependency changes (#2917) that caused this issue. Those changes will be released again as v10.0.0 with the changelog outlining the newly supported Node versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions