Skip to content

Double-check that commits(first: 100 returns the most recent 100 commits, and not the oldest 100 #477

Description

@mmarchini

As title says, our PRCommits.gql query uses first for commits. I'm not sure if it fetches the newest or oldest 100 commits. If whoever implemented this already tested it and remember the answer, that's enough for me too :)

Activity

  1. self-assigned this
    on Aug 15, 2020
  2. targos commented on Aug 15, 2020

    @targos
    Member

    I just tested with https://developer.github.com/v4/explorer for that PR: nodejs/node#34752

    With first: 5, it returns them from oldest to newest:
    image

    You can change to last: 5 to get the most recent commits (still ordered from old to new):

    image

  3. codebytere commented on Aug 17, 2020

    @codebytere
    Member

    Meaning we should swap to last?

  4. mmarchini commented on Aug 17, 2020

    @mmarchini
    ContributorAuthor

    Meaning we should swap to last?

    That's what I understood, yes

  5. github-actions commented on Nov 16, 2020

    @github-actions
    Contributor

    This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions