Repository navigation
No more defaults for git node land? #227
Description
I had to manually set the branch to master and the remote to upstream.
$ git node land 19398
⚠ Remote repository URL does not point to the expected repository nodejs/node
⚠ You have not told git-node what branch you are trying to land commits on.
--------------------------------------------------------------------------------
ℹ For example, if your want to land commits on the `master` branch, you can run:
$ ncu-config set branch master
--------------------------------------------------------------------------------
⚠ You have not told git-node the remote you want to sync with.
--------------------------------------------------------------------------------
ℹ For example, if your remote pointing to nodejs/node is `remote-upstream`, you can run:
$ ncu-config set upstream remote-upstream
--------------------------------------------------------------------------------
$ ncu-config set branch master
Updating local configuration [branch]: undefined -> master
$ ncu-config set upstream upstream
Updating local configuration [upstream]: undefined -> upstream
$ git node land 19398
✔ Done loading data for nodejs/node/pull/19398
Activity
[-]No more defaults for `git node land`[/-][+]No more defaults for `git node land`?[/+]mmarchini commentedon Apr 3, 2018
Defaults were removed on #200.
joyeecheung commentedon Apr 3, 2018
Yes, that was to avoid mistakes of running it in a PR branch
joyeecheung commentedon Apr 6, 2018
This is by design now. Do you want to keep this issue open? @targos
joyeecheung commentedon Apr 6, 2018
Also background: nodejs/node#18914 and #198
targos commentedon Apr 6, 2018
I don't really understand why it has to be like that but OK, no problem.