Skip to content

Handle #issuecomment-371266836 like strings in PR link #206

Description

@gibfahn

Often when you're going through your notifications, you end up with something on the end of the pull request URL, for example:

https://github.com/nodejs/node/pull/19201#issuecomment-371266836
https://github.com/nodejs/node/pull/19201#event-1509291051
https://github.com/nodejs/node/pull/19201/files
https://github.com/nodejs/node/pull/19201#pullrequestreview-102067476

If you run git node metadata https://github.com/nodejs/node/pull/19201#issuecomment-371266836 it just shows the help text.

It should be easy to adjust the regex to handle anything of the form

https://(?:www.)github.com/(\w\+)/(\w\+)/pull/([0-9]+).*

and just capture the three things you need (in ()).

Also https://www.github.com/nodejs/node/pull/19201 doesn't currently work.

Activity

  1. added
    enhancementThings that enhances functionality, provided by node-core-utils
    feature requestNew features for node-core-utils
    on Mar 7, 2018
  2. gibfahn commented on Mar 7, 2018

    @gibfahn
    MemberAuthor

    IDK what the difference between enhancement and feature request is, so I'll ad both 😁.

  3. priyank-p commented on Mar 8, 2018

    @priyank-p
    Contributor

    IDK what the difference between enhancement and feature request is, so I'll ad both 😁.

    I added descriptions to some labels (including enhancements, and feature request), I might not be the best person to add those so maybe some else can add some descriptions :)

  4. gibfahn commented on Mar 9, 2018

    @gibfahn
    MemberAuthor

    Just to add, it looks like you can't currently do git node land https://github.com/nodejs/node/pull/19130.

  5. priyank-p commented on Mar 9, 2018

    @priyank-p
    Contributor

    Just to add, it looks like you can't currently do git node land https://github.com/nodejs/node/pull/19130.

    Can you open a new issue for this? I totally missed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementThings that enhances functionality, provided by node-core-utilsfeature requestNew features for node-core-utils

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions