Repository navigation
PRChecker: Check that semver-major commits have an explanation of breaking changes #108
Description
Activity
Funnily enough, I saw this discussion, and thought "When this lands, this will be a perfect job for the pr_checker".
Anyway: 👍
- changed the title
[-]PRCheker: Check that semver-major commits have an explanation of breaking changes[/-][+]PRChecker: Check that semver-major commits have an explanation of breaking changes[/+]on Nov 12, 2017 To me this is not the job for pr checker, but the job for core-validate-commit: checking commit messages.
True! I had forgotten we had other tools 😄
To me this is not the job for pr checker, but the job for core-validate-commit: checking commit messages.
True! I had forgotten we had other tools
It's not a trivial separation 🤔 - this might not be a simple formatting rule like what
core-validate-commitcheck, it might need to live in the PR description (likeFixes) and require the author's to help...As I see it
core-validate-commit:- Checks formatting rules - all of which the lander can fix (maybe even automatically)
- Is run last in the landing process - just before a
git push- so it is kind of late to stop the land process and ask for new information
IMHO such a failure should block the PR from being ready to land earlier, so that the lander could ask for more information from the author.
@cPhost in term of ❌ / ✔️ I agree.
I also think that having the tool report on the rules for uncommon cases would be very helpful... let's think about this, try to find a smart way to do that.Reacted by Priyank PatelThis issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.
Refs: nodejs/node#16846