napi-asyncworker-example missing scope

node-addon-examples/napi-asyncworker-example/node-addon-api/src/SimpleAsyncWorker.cc

Lines 13 to 16 in dc86a66

    
           void SimpleAsyncWorker::OnOK() { 
        
               std::string msg = "SimpleAsyncWorker returning after 'working' " + std::to_string(runTime) + " seconds."; 
        
               Callback().Call({Env().Null(), String::New(Env(), msg)}); 
        
           };

This seems to be the only example that doesn't call:

Napi::HandleScope scope(Env());

Should this example include that too?

@rynz

@rynz actually, it should be the other way around. Node.js ensures that all scopes are present by the time the OnOK/OnError callbacks get called. Thanks for noticing the discrepancy!

We have additional documentation here: https://github.com/nodejs/node-addon-api/blob/master/doc/object_lifetime_management.md

@gabrielschulhof

@gabrielschulhof thank you!

Can someone who is more familiar with this than I am check to see if there is still bad example code in node-addon-api/doc/async_worker.md It appears that the OnOK example is using the Napi::HandleScope when it is not necessary.

Thanks

Navigation Menu

Repository navigation

napi-asyncworker-example missing scope #142

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	void SimpleAsyncWorker::OnOK() {
	std::string msg = "SimpleAsyncWorker returning after 'working' " + std::to_string(runTime) + " seconds.";
	Callback().Call({Env().Null(), String::New(Env(), msg)});
	};

napi-asyncworker-example missing scope #142

Description

Activity

gabrielschulhof commented on Jun 15, 2020

rynz commented on Jun 15, 2020

gotnone commented on Jul 4, 2020

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions