Skip to content

BigInt::ToWords docs not consistent with implementation  #745

Closed

Description

@adrian-gierakowski

first 2 args are swapped

the docs:

void Napi::BigInt::ToWords(size_t* word_count, int* sign_bit, uint64_t* words);

implementation:

void ToWords(int* sign_bit, size_t* word_count, uint64_t* words);

Activity

  1. changed the title [-]BigInt docs not consistent with implementation [/-] [+]BigInt::ToWords docs not consistent with implementation [/+] on Jun 19, 2020
  2. NickNaso commented on Jun 22, 2020

    @NickNaso
    Member

    @adrian-gierakowski Thanks for your feedback. I made a PR that fix the inconsistency with the documentation.

  3. NickNaso commented on Jun 24, 2020

    @NickNaso
    Member

    I'm closing the issue because #748 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions