Repository navigation
VS 2013 Support #58
Description
Hi all. This issue is for VS 2013 support.
I've got a client who has a number of 3rd party libraries that only compile under VS 2013. This is a continuation of #56. There are some additional notes there.
Here's a gist of the build errors I get when building with --msvs_version=2013: https://gist.github.com/mateodelnorte/7ea8c72e3b2b664ba37da7a0e6ed6dd8.
Thx
Activity
mateodelnorte commentedon Jun 19, 2017
Looks like this issue quickly pooled some +1's. Any ideas on ETA of a PR landing? Trying to prioritize whether I should wait for this, or chug ahead using nan.
nschonni commentedon Jun 20, 2017
I'm not sure if node-gyp still supports 2013 https://github.com/nodejs/node-gyp#option-2
mateodelnorte commentedon Jun 20, 2017
I'd be very surprised if that was the case: https://github.com/nodejs/node-gyp/blob/f6eab1f9e4b160b60b2736bb01a09c83785ba979/gyp/pylib/gyp/MSVSVersion.py#L228-L255
Those are just default instructions for getting running.
kfarnung commentedon Jun 21, 2017
@mateodelnorte I'm taking a look this, but I don't have a timeline for support. I'll let you know when I have some further information.
mateodelnorte commentedon Jun 21, 2017
awesome @kfarnung. thanks!
kfarnung commentedon Jun 23, 2017
@mateodelnorte I think we're pretty close now, take a look at PR #65.
mateodelnorte commentedon Jun 23, 2017
Fantastic! Thanks @kfarnung
jasongin commentedon Jun 26, 2017
Merged as 617dbb6, and published to npm as
node-addon-api@0.3.5tsfn: support direct calls to underlying napi_tsfn
vijaykumbhani commentedon Feb 19, 2021
Hi @jasongin
as per comments, you have fixed the issue at 617dbb6.
can you please say, will this fix include on node-addon-api 3.1.0 later version?
if yes then what will be the approx date of a new version of node-addon-api 3.1.0
Waiting for a reply from your end
tsfn: support direct calls to underlying napi_tsfn
tsfn: support direct calls to underlying napi_tsfn
tsfn: support direct calls to underlying napi_tsfn
tsfn: support direct calls to underlying napi_tsfn