Skip to content

Failures with VS2022 #1491

Description

@mhdawson

I was just adding 23 to the matrix and noticed we should have added testing with VS2022 a while ago.

Seems like there are some failures - https://ci.nodejs.org/job/node-test-node-addon-api-new/nodes=win-vs2022/8773/

Activity

  1. mhdawson commented on May 3, 2024

    @mhdawson
    MemberAuthor

    @vmoroz will take a look.

  2. vmoroz commented on May 3, 2024

    @vmoroz
    Member

    @mhdawson , the code uses std::allocator methods construct and destroy. They were deprecated in in C++17 and removed in C++20. See https://en.cppreference.com/w/cpp/memory/allocator/construct, https://en.cppreference.com/w/cpp/memory/allocator/destroy.
    I will send a PR that fixes it.

  3. KevinEady commented on May 17, 2024

    @KevinEady
    Contributor

    Is this fixed by #1492?

  4. mhdawson commented on May 17, 2024

    @mhdawson
    MemberAuthor

    We took a look at the CI runs in the meeting today and its fixed. Many thanks @vmoroz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions