Repository navigation
Conversation
…NanInitPersistent, introduced NanMakeWeakPersistent
Closed
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Member
|
The tests don't compile with g++ 4.8. 4.8 is more strict in what it accepts than previous versions of gcc. Here is the build error: |
Collaborator
Author
|
I should have fixed everything in #84 now. |
Collaborator
Author
|
Merged into #86 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is my proposal for the new weak API. This works in both 0.10 and newer 0.11.
NanMakeWeakis now useless, so I removed it.NanInitPersistentnever saw much appreciation, and since it can't really be used with weak handles any more, I decided to cut it too. Introduced NanMakeWeakPersistent, which makes aPersistentand sets it weak.I wrote a test which actually does something useful and checks expected behavior of weak handles.
As several thing have been changed and removed, I suggest cleaning up the rest of NAN, making a clean break with outdated 0.11 versions. That will save us a lot of work. If we clean up, this is more or less done. If backwards compatibility (regarding NAN) should be maintained where possible, there is some fixing and testing left to do.
@bnoordhuis Can you review the changes already done? I might have done some horrible mistake, leaking memory or missed a cleaner way of achieving something.