You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
error C2039: 'Holder': is not a member of 'v8::FunctionCallbackInfo<v8::Value>' when using electron 36.0.0-beta.4 #996
We're encountering a breaking issue when building native modules using nan@2.22.2 in combination with Electron v36.0.0-beta.4.
The issue arises due to the use of info.Holder() in nan_callbacks_12_inl.h(112,62) In newer versions of V8, particularly as used in Electron 36, info.Holder() is not a valid member of FunctionCallbackInfo. This results in the following build error:
electron-quick-start-main-v36\node_modules\nan\nan_callbacks_12_inl.h(112,62): error C2039: 'Holder': is not a member of
'v8::FunctionCallbackInfo<v8::Value>' [electron-quick-start-main-v36\native\test\build\test.vcxproj]
Activity
szegedi commentedon May 6, 2025
Same issue happens when trying to compile C++ code using Nan targeting the just released Node.js 24.0.0.
Apollon77 commentedon May 7, 2025
Same issue with Node.js 24
bimalkjha commentedon Jun 12, 2025
PR #979 has fix for this issue. Thanks.
agracio commentedon Jun 17, 2025
PR #1000. Fingers crossed it will be accepted.
Apollon77 commentedon Jul 25, 2025
seems nan 2.23.0 fixes it?
agracio commentedon Jul 25, 2025
Yes
Apollon77 commentedon Jul 25, 2025
Then this issue can be closed
agracio commentedon Jul 25, 2025
It is up to the author or nan maintainers.
bimalkjha commentedon Jul 26, 2025
Yes, issue is fixed and it can be closed. Thanks.
oalfroukh commentedon Jul 27, 2025
Hi,
I confirm that I'm not able to reproduce the issue on
v2.23.0, so I'm closing the issue.