Repository navigation
Conversation
Drieger
force-pushed
the
findrefs_context
branch
2 times, most recently
from
September 4, 2018 20:49
b3a46bf to
9981ec3
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
Author
|
@mmarchini I just finished suggested changes |
Drieger
force-pushed
the
findrefs_context
branch
from
September 12, 2018 13:20
0615ea6 to
fcdf2d9
Compare
When using `findrefs` we should be able to get all references for the given value, this includes `Context` objects. Refs: nodejs#195
Drieger
force-pushed
the
findrefs_context
branch
from
September 17, 2018 11:07
fcdf2d9 to
d174865
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
Author
|
@mmarchini Last three comments were addressed on last commit |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Drieger
force-pushed
the
findrefs_context
branch
from
September 21, 2018 14:15
7b3589b to
8eb912e
Compare
Drieger
force-pushed
the
findrefs_context
branch
from
September 24, 2018 19:01
ce74b4d to
6560381
Compare
Contributor
Author
|
@joyeecheung I think all change requests were addressed I created a different function for the symbol lookup, this will allow to use it anywhere else if necessary. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Member
|
Landed in 089dcc9, thanks! |
hyj1991
pushed a commit
to aliyun-node/llnode
that referenced
this pull request
Sep 26, 2018
When using `findrefs` we should be able to get all references for the given value, this includes `Context` objects. Refs: nodejs#195 PR-URL: nodejs#227 Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
findrefswe should be able to get all referencesfor the given value, this includes
Contextobjects.Refs: #195
Sample output:
