Consider performance improvements comming from PR to llparse #260

Activity

1. ngrodzitski

   changed the title [-]Cnsider performance improvements comming from PR to llparse[/-] [+]Consider performance improvements comming from PR to llparse[/+] on Oct 27, 2023
2. lemire commented on Nov 8, 2023

   

   lemire

   on Nov 8, 2023

   Member

   More actions

   How did you assess the benefits experimentally?

   PR nodejs/llparse#58 bears on TableLookup. Correct? Is TableLookup used in llhttp directly or indirectly in llhttp?

   Is llhttp built with support for SSSE3 or SSE4.2? I see some flag in the tests, but unless that's also used by Node.js when building for production use, then that's not very useful.
3. ngrodzitski commented on Nov 8, 2023

   

   ngrodzitski

   on Nov 8, 2023

   Last edited by ngrodzitski

   ContributorAuthor

   More actions

   That is how I did the benchmark:

   1. Cloned llparse and llhttp locally.
   2. Did the changes in llparse.
   3. Used npm-link so that my llocal llparse version is used in llhttp.
   4. Rebuild llhttp and run a benchmark.

   Is llhttp built with support for SSSE3 or SSE4.2? I see some flag in the tests, but unless that's also used by Node.js when building for production use, then that's not very useful.

   I'm afraid I don't understand how the build of llhttp works, but to verify the changes I temporary modify llparse to provide bad code under SSE-guard macro (like adding #error "Just checking...") and then I can see that the build of llhttp fails.

   Here the a way to run benchmarks (I rerun it after modification to local llparse):

   cd <base_dir>/llhttp
   npm link ../llparse
   npm run build
   npm run test
   npm run bench
   

   I guess that is not a best way to do it, but that is what my expertise in js-stuff was able to came up with.
4. ShogunPanda commented on Feb 6, 2024

   

   ShogunPanda

   on Feb 6, 2024

   Contributor

   More actions

   Not considering this for now.
   Nobody is maintaining llparse at the moment so we don't really know the infrastructure risk associated with it.
5. ShogunPanda

   closed this as not plannedon Feb 6, 2024