Skip to content
This repository was archived by the owner on Nov 21, 2018. It is now read-only.

1.0.0 (Work in Progress, Releases on Jan 13th) - #27

Merged
Fishrock123 merged 26 commits into
masterfrom
1.0.0
Jan 14, 2015
Merged

Fishrock123 merged 26 commits into
masterfrom
1.0.0

Conversation

@mikeal

@mikeal mikeal commented Jan 12, 2015

Copy link
Copy Markdown
Contributor

I've improved the messaging, cut out a section for releases, and matched the css to the colors in the logo for the initial release.

Should implement all of #25

@snostorm

Copy link
Copy Markdown
Contributor

For those curious what it looks like. I do prefer the return to a white scheme over the back.

My one "nit pick" would be the lines between the logo / Beta / date / etc. being a bit too dark.

iojs-v1 0-screenshot

@mikeal

mikeal commented Jan 12, 2015

Copy link
Copy Markdown
Contributor Author

Ok, we now have a webpage for ES6 stuff. It is lifted from https://github.com/seegno/io.js/wiki/The-state-of-ES6-on-io.js so I'd like to get @seegno's signoff.

I also linked all the features so that people have an easier time learning more. Would love to get that proofed by @domenic.

@domenic

domenic commented Jan 12, 2015

Copy link
Copy Markdown
Contributor

Where is it to review? I'd prefer to avoid reviewing the raw HTML if possible.

@mikeal

mikeal commented Jan 12, 2015

Copy link
Copy Markdown
Contributor Author

hrm.... ya, GitHub should add that feature :)

@ruimarinho

Copy link
Copy Markdown

@mikeal wdyt of adding target blank to all external links?

Comment thread es6.html

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

@Fishrock123

Copy link
Copy Markdown
Contributor

Hmm, the yellow link text is somewhat difficult to read.

Comment thread es6.html Outdated

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

@mikeal

mikeal commented Jan 12, 2015

Copy link
Copy Markdown
Contributor Author

@Fishrock123

Hmm, the yellow link text is somewhat difficult to read.

Yeah, I'm tying to match to the colors in the logo but they aren't entirely ideal.

Comment thread es6.html

This comment was marked as off-topic.

@Fishrock123

Copy link
Copy Markdown
Contributor

Yeah, I'm tying to match to the colors in the logo but they aren't entirely ideal.

I don't think that should be the aim. Can't we make something logo-agnostic? Also did we confirm this was the logo that is being used for 1.0.0?

@mikeal

mikeal commented Jan 12, 2015

Copy link
Copy Markdown
Contributor Author

@Fishrock123 my thinking was that we could eventually templatize the colors and then swap them out for each release based on that logo :)

@Fishrock123

Copy link
Copy Markdown
Contributor

my thinking was that we could eventually templatize the colors and then swap them out for each release based on that logo :)

I had also thought about that, but it seems like it would be a lot more work and/or radical design changes too often? Not sure.

Comment thread es6.html

This comment was marked as off-topic.

Comment thread es6.html Outdated

This comment was marked as off-topic.

@ruimarinho

Copy link
Copy Markdown

Should we add 1 or 2 anchors so that devs can quickly share links around? The FAQ isn't that lengthy right now, but it will probably keep expanding.

Comment thread index.html Outdated

This comment was marked as off-topic.

@ruimarinho

Copy link
Copy Markdown

@mikeal do you want me to update @seegno's wiki to point to the official FAQ (as soon as the website is published) and add a suggestion there on how to contribute to its content?

@fixe

fixe commented Jan 13, 2015

Copy link
Copy Markdown

@mikeal what do you think about using a yellow background (#f5da55) instead?

screen shot 2015-01-12 at 23 58 21

@mikeal

mikeal commented Jan 13, 2015

Copy link
Copy Markdown
Contributor Author

Ok, there's too much feedback for me to process all of it. If you turn feedback in to a PR to the 1.0.0 branch I can probably take it.

@Fishrock123
Fishrock123 deleted the 1.0.0 branch January 13, 2015 21:38
@Fishrock123

Copy link
Copy Markdown
Contributor

oh shit

i give up on git

@Fishrock123
Fishrock123 restored the 1.0.0 branch January 13, 2015 21:43
@Fishrock123 Fishrock123 reopened this Jan 13, 2015
@snostorm

Copy link
Copy Markdown
Contributor

@Fishrock123 I think I prefer having the "logo" / title versus nav links in slightly different shades (hence why I put them a bit brighter.) FYI another PR queued up for responsiveness, #32

@Fishrock123 Fishrock123 mentioned this pull request Jan 13, 2015
- With the current footer nav items, we need to collapse
  it earlier (560px)
- Collapse the download more < 410px
@Fishrock123

Copy link
Copy Markdown
Contributor

This is landable upon release as a fully static site, beyond what we have we need to start doing things dynamically, and that is beyond the scope of this PR I feel.

@Fishrock123

Copy link
Copy Markdown
Contributor

Note to self: update the docs link before closing.

@snostorm

Copy link
Copy Markdown
Contributor

Agreed on moving to dynamic sooner than later @Fishrock123. I was waiting for the "big launch" and the site to stabilize around it before daring to put up a proof-of-concept PR for it myself. We can continue that on #22.

Should we ping the open issues on mainline repo re: 1.0.0 that the site is more-or-less in a merge ready state for when they go live?

@Fishrock123

Copy link
Copy Markdown
Contributor

Should we ping the open issues on mainline repo re: 1.0.0 that the site is more-or-less in a merge ready state for when they go live?

oh. Yeah. i forgot there were issue(s) over there.

Fishrock123 added a commit that referenced this pull request Jan 14, 2015
1.0.0 Release Website
@Fishrock123
Fishrock123 merged commit 41002a2 into master Jan 14, 2015
@rvagg

rvagg commented Jan 14, 2015

Copy link
Copy Markdown
Member

good work everyone involved in this!

@mikeal

mikeal commented Jan 14, 2015

Copy link
Copy Markdown
Contributor Author

Amazing job everybody!

@snostorm
snostorm deleted the 1.0.0 branch January 14, 2015 15:29
snostorm pushed a commit that referenced this pull request Feb 27, 2015
Flytte /blogg.html over til /blogg
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants