Skip to content
This repository was archived by the owner on Dec 16, 2021. It is now read-only.

add link and message to nodeschool upon successful installation #4 - #22

Merged
JoeDoyle23 merged 2 commits into
nodejs:masterfrom
azat-co:nodeschool
Aug 5, 2016
Merged

JoeDoyle23 merged 2 commits into
nodejs:masterfrom
azat-co:nodeschool

Conversation

@azat-co

@azat-co azat-co commented Jul 2, 2016

Copy link
Copy Markdown
Contributor

how about something like this for #4?

@azat-co azat-co changed the title add link and message to nodeschool upon successful installation #4 add the link and message to nodeschool upon successful installation #4 Jul 2, 2016
@azat-co azat-co changed the title add the link and message to nodeschool upon successful installation #4 add link and message to nodeschool upon successful installation #4 Jul 2, 2016
@Fishrock123

Copy link
Copy Markdown
Contributor

@mikeal

@mikeal

mikeal commented Jul 5, 2016

Copy link
Copy Markdown
Contributor

This is a great start. I think that eventually we'll want to expand this but it's good to have this in there now so that we message the purpose of the installer a bit better as a vehicle for on-boarding.

@mikeal

mikeal commented Jul 5, 2016

Copy link
Copy Markdown
Contributor

There's a merge conflict tho :(

@azat-co

azat-co commented Jul 9, 2016 •

Copy link
Copy Markdown
Contributor Author

screenshot 2016-07-08 22 56 01
@mikeal I merged the conflicts. Please check/merge :)

While there, I added node logo and made boxes have same width (prettier).

@azat-co

azat-co commented Jul 24, 2016

Copy link
Copy Markdown
Contributor Author

@mikeal good or no good?

@azat-co azat-co mentioned this pull request Jul 24, 2016
@JoeDoyle23
JoeDoyle23 merged commit 888bf80 into nodejs:master Aug 5, 2016
@azat-co

azat-co commented Aug 10, 2016

Copy link
Copy Markdown
Contributor Author

@JoeDoyle23 thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants