Skip to content
This repository was archived by the owner on Jul 6, 2018. It is now read-only.

http2: fix multivalued headers and cookies - #115

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:make-cookies-work
Closed

jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:make-cookies-work

Conversation

@jasnell

@jasnell jasnell commented May 15, 2017

Copy link
Copy Markdown
Member
  • mapToHeaders function was not working correctly
  • ensure that cookie headers are reassembled properly
  • add test
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

http2

@jasnell jasnell mentioned this pull request May 15, 2017
sebdeckers

This comment was marked as off-topic.

* mapToHeaders function was not working correctly
* ensure that cookie headers are reassembled properly
* add test
* use internal/errors in util
@jasnell
jasnell force-pushed the make-cookies-work branch from 1510bcf to 955f3ed Compare May 15, 2017 19:40
sebdeckers

This comment was marked as off-topic.

jasnell added a commit that referenced this pull request May 16, 2017
* mapToHeaders function was not working correctly
* ensure that cookie headers are reassembled properly
* add test
* use internal/errors in util

PR-URL: #115
Reviewed-By: Sebastiaan Deckers <sebdeckers83@gmail.com>
@jasnell

jasnell commented May 16, 2017

Copy link
Copy Markdown
Member Author

Landed!

@jasnell jasnell closed this May 16, 2017
jasnell added a commit that referenced this pull request May 19, 2017
* mapToHeaders function was not working correctly
* ensure that cookie headers are reassembled properly
* add test
* use internal/errors in util

PR-URL: #115
Reviewed-By: Sebastiaan Deckers <sebdeckers83@gmail.com>
jasnell added a commit that referenced this pull request May 31, 2017
* mapToHeaders function was not working correctly
* ensure that cookie headers are reassembled properly
* add test
* use internal/errors in util

PR-URL: #115
Reviewed-By: Sebastiaan Deckers <sebdeckers83@gmail.com>
jasnell added a commit to jasnell/http2-1 that referenced this pull request Jun 22, 2017
* mapToHeaders function was not working correctly
* ensure that cookie headers are reassembled properly
* add test
* use internal/errors in util

PR-URL: nodejs#115
Reviewed-By: Sebastiaan Deckers <sebdeckers83@gmail.com>
jasnell added a commit to jasnell/http2-1 that referenced this pull request Jul 10, 2017
* mapToHeaders function was not working correctly
* ensure that cookie headers are reassembled properly
* add test
* use internal/errors in util

PR-URL: nodejs#115
Reviewed-By: Sebastiaan Deckers <sebdeckers83@gmail.com>
jasnell added a commit to jasnell/http2-1 that referenced this pull request Jul 14, 2017
* mapToHeaders function was not working correctly
* ensure that cookie headers are reassembled properly
* add test
* use internal/errors in util

PR-URL: nodejs#115
Reviewed-By: Sebastiaan Deckers <sebdeckers83@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants