Repository navigation
http2: status of push API #67
Description
Activity
Question: Do we want to support legacy APIs?
test-http-set-cookies.jsuses a currently not documented way to set headers (note the nested array instead of a flat object):res.writeHead(200, [['set-cookie', 'A'], ['set-cookie', 'B'], ['content-type', 'text/plain']]);
I'm in favor of just supporting objects. However I remember somehow from this morning that the goal is to support as much of the old behaviour as possible. What do you think @nodejs/http2 ?
@robertkowalski I'd focus on documented behavior.
For now, definitely focus on documented behavior. We can revisit this once we have that done and working.
🤔 Is this issue discussing server push support or header API compatibility?
The compatibility layer in #47 tries to stay true to the documented APIs, for headers on the request and response. Cookies are not yet supported. I don't think it's prohibitively difficult but would rather leave it for a separate PR.
FWIW, core currently uses an Object for headers and trailers. That could be changed to using a Map or linked list.
I think we can close this now.
placeholder from the collab summit in Berlin