Repository navigation
a better default configuration for TLS connection of http2 #59
Description
Activity
The
ALPN/NPNbit should already be handled internally by the code. If it's not, then that's definitely a bug. For the SNI, that should be able to be passed in on theoptionsbut I haven't tested it yet.I think you're talking about the servers, but I was talking about the clients (sorry I wasn't clear).
The http2 client sockets are initialized around https://github.com/nodejs/http2/blob/master/lib/internal/http2/core.js#L1238 but no ALPN/NPN are specified yet, if I understand correctly.
SNI can be specified through
optionsindeed, but (for the clients) I think it's better to specify the host name by default, otherwise an http2 connection request will look likehttp2.connect("https://http2.golang.org/", {servername: 'http2.golang.org'})which are really redundant.Ok. I'll verify shortly and will make the sni change. Thank you!
- added 2 commits that reference this issue
on May 2, 2017 - added a commit that references this issue
on May 19, 2017 - added a commit that references this issue
on May 31, 2017 - added a commit that references this issue
on Jun 22, 2017 - added 2 commits that reference this issue
on Jul 10, 2017
It seems the TLS socket is initialized as
tls.connect(port, host, options)inhttp2.connect. Some existing HTTP2 servers require some TLS options to set up the connection properly. More specifically:I believe those should be set by defaults, then passing a URL string will just work.
Also, maybe it's better to use
secureConnectevent instead ofconnectevent for the TLS sockets for setting up a session -- so that it won't go into the session if some TLS setup failure happens.