Check to determine if global.Promise is native promise #557

Activity

1. addaleax commented on Mar 29, 2017

   

   addaleax

   on Mar 29, 2017

   Member

   More actions

   The “official” way would be value instanceof Promise, the “correct” way that works across VM contexts would be process.binding('util').isPromise(value) (see nodejs/node-eps#44 for a proposal turning the latter into a public Node API).
2. ORESoftware commented on Mar 29, 2017

   

   ORESoftware

   on Mar 29, 2017

   Last edited by ORESoftware

   Author

   More actions

   hmmm
   sorry, I should been more detailed

   global.Promise  = require('bluebird')
   value instanceof Promise // will return true, but not indicate we are using native promises

   but the second methodology should work I think, right?
3. addaleax commented on Mar 29, 2017

   

   addaleax

   on Mar 29, 2017

   Member

   More actions

   Ah, right, should have read that you were asking for checking global.Promise, not a promise.

   Yes, the second way should work.
4. ORESoftware commented on Mar 29, 2017

   

   ORESoftware

   on Mar 29, 2017

   Last edited by ORESoftware

   Author

   More actions

   process.binding('util') is the same as require('util') or no?
5. addaleax commented on Mar 29, 2017

   

   addaleax

   on Mar 29, 2017

   Member

   More actions

   process.binding('util') is the same as require('util') or no?

   No, process.binding() gives you direct access to Node’s internal C++ APIs. It’s not part of our public API, so don’t rely on it being there forever. (Sorry – I fear that’s the best answer we have right now. If you want something more reliable, maybe engage in nodejs/node-eps#44 …)

   👍React with 👍2Reacted by Alexander Mills and Nadeem Ramsing
6. ORESoftware commented on Mar 29, 2017

   

   ORESoftware

   on Mar 29, 2017

   Author

   More actions

   sure will do thanks!
7. Knighton910

   closed this as completedon Jun 15, 2017