Receive pid that signal was sent from #4075

Activity

1. mehulkar commented on Jan 17, 2023

   

   mehulkar

   on Jan 17, 2023

   Author

   More actions

   It seems this is where the signal handler is setup here: https://github.com/nodejs/node/blob/66b1356ebcf55e477639a52baba3067afd9ea7a0/deps/uv/src/unix/signal.c#L224-L242

   and according to the sigaction docs, it needs to set sa_sigaction and a SA_SIGINFO flag.

   -  sa.sa_handler = uv__signal_handler;
   -  sa.sa_flags = SA_RESTART;
   +  sa.sa_sigaction = uv__signal_handler;
   +  sa.sa_flags = SA_SIGINFO;

   I have no real understanding of how this works, this is all based on a couple hours of research that I wrote down here. I'm looking for some guidance about:

   1. Whether this is possible to do already, and I'm looking in the wrong place
   2. If it did require a patch to "make it work", where else would I also have to patch such that the process.on callback actually gets the information? (I tried building node with the patch above and it didn't Just Work™)
   3. Is it desirable to add this information into signal handling always or with an option? Changing the callback signature is a breaking change, so I imagine it would need an option.
   4. If I'm right about how this works, is there some history here about why it works this way, or is it entirely dependent on libuv (and should I ask someone there?)

   Thank you!
2. gireeshpunathil commented on Jan 17, 2023

   

   gireeshpunathil

   on Jan 17, 2023

   Member

   More actions

   thanks @mehulkar - this is very detailed research work indeed! I will attempt to answer some:

   • 1. no, this is not already possible.
   • 2. the PR you referred (src: set SA_SIGINFO flag when using sa_sigaction node#34648) is potentially abandoned because of portability issues - Node.js is supported in many platforms, and some platforms implement signal handling minimally
   • 3. this is definitely a useful info, and desirable to add it always. However, point 2 poses challenge IMO. Please feel free to resurrect 34648 and see if you can progress.
   • 4. no idea.
   • /cc @richardlau , who may be able to provide additional insight as well as guidance.

   Again, this is a great ground work, and wishing you good luck with working in Node.js!
3. richardlau commented on Jan 17, 2023

   

   richardlau

   on Jan 17, 2023

   Member

   More actions

   • 2. the PR you referred (src: set SA_SIGINFO flag when using sa_sigaction node#34648) is potentially abandoned because of portability issues - Node.js is supported in many platforms, and some platforms implement signal handling minimally

   I have suspicions that the AIX behaviour is faulty and that there is an AIX bug there but I was unable to find the right person/group within IBM to pursue any further and now I'm outside of IBM. The behaviour on AIX was an outlier -- all other platforms I tested returned the signal information to the handler (see https://github.com/richardlau/signals).

   👍React with 👍1Reacted by Gireesh Punathil
4. preveen-stack

   added

   macos

   on Jun 22, 2023
5. preveen-stack commented on Aug 25, 2023

   

   preveen-stack

   on Aug 25, 2023

   Contributor

   More actions

   cc @nodejs/platform-macos PTAL
6. github-actions commented on May 7, 2024

   

   github-actionsbot

   on May 7, 2024 – with GitHub Actions

   More actions

   It seems there has been no activity on this issue for a while, and it is being closed in 30 days. If you believe this issue should remain open, please leave a comment.
   If you need further assistance or have questions, you can also search for similar issues on Stack Overflow.
   Make sure to look at the README file for the most updated links.
7. github-actions

   added

   stale

   on May 7, 2024
8. github-actions commented on Jun 7, 2024

   

   github-actionsbot

   on Jun 7, 2024 – with GitHub Actions

   More actions

   It seems there has been no activity on this issue for a while, and it is being closed. If you believe this issue should remain open, please leave a comment.
   If you need further assistance or have questions, you can also search for similar issues on Stack Overflow.
   Make sure to look at the README file for the most updated links.
9. github-actions

   closed this as not plannedon Jun 7, 2024