Missing labels #79

Activity

1. phillipj

   added

   bug

   on Sep 17, 2016
2. sejoker commented on Sep 18, 2016

   

   sejoker

   on Sep 18, 2016

   Last edited by sejoker

   Contributor

   More actions

   I am curious how to check log files in case we got an error from Github. In that case, we should have a message 'Error retrieving files from GitHub' in the logs or any other relevant debug information about the PR in question.
3. mscdex commented on Sep 18, 2016

   

   mscdex

   on Sep 18, 2016

   ContributorAuthor

   More actions

   Your guess is as good as mine. I've never tried to run my own instance of the bot before.
4. jbergstroem commented on Sep 18, 2016

   

   jbergstroem

   on Sep 18, 2016

   Member

   More actions

   We use Bunyan so logs are available on the host as well as over http (with a secret). I'm sure @phillipj can provide the access key to those that wants to fiddle.
5. phillipj commented on Sep 18, 2016

   

   phillipj

   on Sep 18, 2016

   Member

   More actions

   Absolutely! Just ping me on IRC and I'll give you the URL

   On Sunday, 18 September 2016, Johan Bergström notifications@github.com
   wrote:

   We use Bunyan so logs are available on the host as well as over http (with
   a secret). I'm sure @phillipj https://github.com/phillipj can provide
   the access key to those that wants to fiddle.

   —
   You are receiving this because you were mentioned.
   Reply to this email directly, view it on GitHub
   #79 (comment),
   or mute the thread
   https://github.com/notifications/unsubscribe-auth/ABLLExztPLaj9W8Nr2ysYZLLzFhGkroHks5qrVasgaJpZM4J_nO0
   .
6. phillipj commented on Sep 19, 2016

   

   phillipj

   on Sep 19, 2016

   Member

   More actions

   Had a look in the logs and found this:

   [2016-09-17T11:42:06.032+02:00] ERROR: bot/15719 on server-05: Error retrieving files from GitHub (req_id=8dfe80e7-e6dd-4144-9eff-5c81afb17e88, pr=nodejs/node/#8600, action=pull_request.opened)
       err: {
         "code": 404,
         "status": "Not Found",
         "message": "{\"message\":\"Not Found\",\"documentation_url\":\"https://developer.github.com/v3\"}"
       }
   

   I assume there was some inconsistencies in GitHub's side which caused this error, while trying to retrieve the files related to the mentioned PR :/

   Maybe the bot should wait a couple of seconds before doing its thing, as it's not important that these labels gets added instantaneously.
7. sejoker commented on Sep 19, 2016

   

   sejoker

   on Sep 19, 2016

   Contributor

   More actions

   @phillipj thanks for follow up, you confirmed my initial assumption. A short timeout like you suggested would be sufficient as the first step. If necessary, more complicated setup with retry logic will need to take place.
8. sejoker commented on Sep 19, 2016

   

   sejoker

   on Sep 19, 2016

   Contributor

   More actions

   I could prepare a PR if we agree on the possible fix.
9. phillipj commented on Sep 19, 2016

   

   phillipj

   on Sep 19, 2016

   Member

   More actions

   @sejoker a PR would be great 👍
10. sejoker

    added a commit that references this issue on Sep 19, 2016

    labels: defer resolving labels

    ...

    0e3bb57
11. sejoker commented on Sep 19, 2016

    

    sejoker

    on Sep 19, 2016

    Contributor

    More actions

    @phillipj your feedback on #81 will be valuable.
12. sejoker

    added a commit that references this issue on Sep 20, 2016

    labels: defer resolving labels

    ...

    d646bac
13. phillipj

    closed this as completedin #81on Sep 21, 2016
14. phillipj

    added a commit that references this issue on Sep 21, 2016

    labels: defer resolving labels (#81)

    ...

    51aa6f5
15. phillipj commented on Sep 21, 2016

    

    phillipj

    on Sep 21, 2016

    Member

    More actions

    FYI now that @sejoker PR is merged, the bot will wait for 2 seconds before resolving labels
16. phillipj

    added 2 commits that reference this issue on Mar 6, 2021

    Remove waiting for 2 seconds before resolving labels

    ...

    9252057

    Remove waiting for 2 seconds before resolving labels

    ...

    d6cdb0e