Skip to content

Update v8.x to v8.9.0 - #563

Merged
SimenB merged 1 commit into
masterfrom
nodejs-8.9.0
Nov 1, 2017
Merged

SimenB merged 1 commit into
masterfrom
nodejs-8.9.0

Conversation

@PeterDaveHello

@PeterDaveHello PeterDaveHello commented Oct 31, 2017 •

Copy link
Copy Markdown
Member

@PeterDaveHello
PeterDaveHello requested a review from a team October 31, 2017 18:22
LaurentGoderre

This comment was marked as off-topic.

@PeterDaveHello

PeterDaveHello commented Oct 31, 2017 •

Copy link
Copy Markdown
Member Author

hmmm ... this one failed: https://travis-ci.org/nodejs/docker-node/jobs/295426993, I'll run the test locally now.

chorrell

This comment was marked as off-topic.

SimenB

This comment was marked as off-topic.

@chorrell

Copy link
Copy Markdown
Contributor

The test build fails for me locally:

$ ./test-build.sh 8.9
Building 8.9.0...
Sending build context to Docker daemon  20.99kB
Step 1/8 : FROM buildpack-deps:jessie
jessie: Pulling from library/buildpack-deps
85b1f47fba49: Pull complete 
5409e9a7fa9e: Pull complete 
661393707836: Pull complete 
1bb98c08d57e: Pull complete 
Digest: sha256:31016a37ea5d794b9f8bbd8978edb01292947f3e683174754c3bfecbd5760dc3
Status: Downloaded newer image for buildpack-deps:jessie
 ---> 29080191541e
Step 2/8 : RUN groupadd --gid 1000 node   && useradd --uid 1000 --gid node --shell /bin/bash --create-home node
 ---> Running in a7aad69c15d3
 ---> ebcf3664b9c7
Removing intermediate container a7aad69c15d3
Step 3/8 : RUN set -ex   && for key in     94AE36675C464D64BAFA68DD7434390BDBE9B9C5     FD3A5288F042B6850C66B31F09FE44734EB7990E     71DCFD284A79C3B38668286BC97EC7A07EDE3FC1     DD8F2338BAE7501E3DD5AC78C273792F7D83545D     C4F0DFFF4E8C1A8236409D08E73BC641CC11F4C8     B9AE9905FFD7803F25714661B63B535A4C206CA9     56730D5401028683275BD23C23EFEFE93C4CFFFE   ; do     gpg --keyserver pgp.mit.edu --recv-keys "$key" ||     gpg --keyserver keyserver.pgp.com --recv-keys "$key" ||     gpg --keyserver ha.pool.sks-keyservers.net --recv-keys "$key" ;   done
 ---> Running in 7b64ca985ff1
+ gpg --keyserver pgp.mit.edu --recv-keys 94AE36675C464D64BAFA68DD7434390BDBE9B9C5
gpg: directory `/root/.gnupg' created
gpg: new configuration file `/root/.gnupg/gpg.conf' created
gpg: WARNING: options in `/root/.gnupg/gpg.conf' are not yet active during this run
gpg: keyring `/root/.gnupg/secring.gpg' created
gpg: keyring `/root/.gnupg/pubring.gpg' created
gpg: requesting key DBE9B9C5 from hkp server pgp.mit.edu
gpg: /root/.gnupg/trustdb.gpg: trustdb created
gpg: key DBE9B9C5: public key "Colin Ihrig <cjihrig@gmail.com>" imported
gpg: no ultimately trusted keys found
gpg: Total number processed: 1
gpg:               imported: 1  (RSA: 1)
+ gpg --keyserver pgp.mit.edu --recv-keys FD3A5288F042B6850C66B31F09FE44734EB7990E
gpg: requesting key 4EB7990E from hkp server pgp.mit.edu
gpg: key 4EB7990E: public key "Jeremiah Senkpiel <fishrock123@rocketmail.com>" imported
gpg: no ultimately trusted keys found
gpg: Total number processed: 1
gpg:               imported: 1  (RSA: 1)
+ gpg --keyserver pgp.mit.edu --recv-keys 71DCFD284A79C3B38668286BC97EC7A07EDE3FC1
gpg: requesting key 7EDE3FC1 from hkp server pgp.mit.edu
gpg: key 7EDE3FC1: public key "keybase.io/jasnell <jasnell@keybase.io>" imported
gpg: no ultimately trusted keys found
gpg: Total number processed: 1
gpg:               imported: 1  (RSA: 1)
+ gpg --keyserver pgp.mit.edu --recv-keys DD8F2338BAE7501E3DD5AC78C273792F7D83545D
gpg: requesting key 7D83545D from hkp server pgp.mit.edu
gpg: key 7D83545D: public key "Rod Vagg <rod@vagg.org>" imported
gpg: no ultimately trusted keys found
gpg: Total number processed: 1
gpg:               imported: 1  (RSA: 1)
+ gpg --keyserver pgp.mit.edu --recv-keys C4F0DFFF4E8C1A8236409D08E73BC641CC11F4C8
gpg: requesting key CC11F4C8 from hkp server pgp.mit.edu
gpg: key CC11F4C8: public key "Myles Borins <myles.borins@gmail.com>" imported
gpg: no ultimately trusted keys found
gpg: Total number processed: 1
gpg:               imported: 1  (RSA: 1)
+ gpg --keyserver pgp.mit.edu --recv-keys B9AE9905FFD7803F25714661B63B535A4C206CA9
gpg: requesting key 4C206CA9 from hkp server pgp.mit.edu
gpg: key 4C206CA9: public key "Evan Lucas <evanlucas@me.com>" imported
gpg: no ultimately trusted keys found
gpg: Total number processed: 1
gpg:               imported: 1  (RSA: 1)
+ gpg --keyserver pgp.mit.edu --recv-keys 56730D5401028683275BD23C23EFEFE93C4CFFFE
gpg: requesting key 3C4CFFFE from hkp server pgp.mit.edu
gpg: key 3C4CFFFE: public key "Italo A. Casas <me@italoacasas.com>" imported
gpg: no ultimately trusted keys found
gpg: Total number processed: 1
gpg:               imported: 1  (RSA: 1)
 ---> 58d3e6b62117
Removing intermediate container 7b64ca985ff1
Step 4/8 : ENV NODE_VERSION 8.9.0
 ---> Running in 74ffbfa9a8f0
 ---> 4c77f2be02a5
Removing intermediate container 74ffbfa9a8f0
Step 5/8 : RUN ARCH= && dpkgArch="$(dpkg --print-architecture)"   && case "${dpkgArch##*-}" in     amd64) ARCH='x64';;     ppc64el) ARCH='ppc64le';;     s390x) ARCH='s390x';;     arm64) ARCH='arm64';;     armhf) ARCH='armv7l';;     *) echo "unsupported architecture"; exit 1 ;;   esac   && curl -SLO "https://nodejs.org/dist/v$NODE_VERSION/node-v$NODE_VERSION-linux-$ARCH.tar.xz"   && curl -SLO --compressed "https://nodejs.org/dist/v$NODE_VERSION/SHASUMS256.txt.asc"   && gpg --batch --decrypt --output SHASUMS256.txt SHASUMS256.txt.asc   && grep " node-v$NODE_VERSION-linux-$ARCH.tar.xz\$" SHASUMS256.txt | sha256sum -c -   && tar -xJf "node-v$NODE_VERSION-linux-$ARCH.tar.xz" -C /usr/local --strip-components=1   && rm "node-v$NODE_VERSION-linux-$ARCH.tar.xz" SHASUMS256.txt.asc SHASUMS256.txt   && ln -s /usr/local/bin/node /usr/local/bin/nodejs
 ---> Running in 4b8ef4c84248
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 10.8M  100 10.8M    0     0  4656k      0  0:00:02  0:00:02 --:--:-- 4657k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2651    0  2651    0     0  10612      0 --:--:-- --:--:-- --:--:-- 10604
gpg: Signature made Tue Oct 31 18:38:23 2017 UTC using RSA key ID 821C587A
gpg: Can't check signature: public key not found
The command '/bin/sh -c ARCH= && dpkgArch="$(dpkg --print-architecture)"   && case "${dpkgArch##*-}" in     amd64) ARCH='x64';;     ppc64el) ARCH='ppc64le';;     s390x) ARCH='s390x';;     arm64) ARCH='arm64';;     armhf) ARCH='armv7l';;     *) echo "unsupported architecture"; exit 1 ;;   esac   && curl -SLO "https://nodejs.org/dist/v$NODE_VERSION/node-v$NODE_VERSION-linux-$ARCH.tar.xz"   && curl -SLO --compressed "https://nodejs.org/dist/v$NODE_VERSION/SHASUMS256.txt.asc"   && gpg --batch --decrypt --output SHASUMS256.txt SHASUMS256.txt.asc   && grep " node-v$NODE_VERSION-linux-$ARCH.tar.xz\$" SHASUMS256.txt | sha256sum -c -   && tar -xJf "node-v$NODE_VERSION-linux-$ARCH.tar.xz" -C /usr/local --strip-components=1   && rm "node-v$NODE_VERSION-linux-$ARCH.tar.xz" SHASUMS256.txt.asc SHASUMS256.txt   && ln -s /usr/local/bin/node /usr/local/bin/nodejs' returned a non-zero code: 2
**********
Build of 8.9.0 failed!
**********

Was this release signed with a new sig?

@SimenB

SimenB commented Oct 31, 2017

Copy link
Copy Markdown
Member

@gibfahn ^

@chorrell

Copy link
Copy Markdown
Contributor

I think we are missing the 77984A986EBC2AA786BC0F66B01FBB92821C587A gpg key

https://github.com/nodejs/node#release-team

@SimenB

SimenB commented Oct 31, 2017

Copy link
Copy Markdown
Member

nodejs/node@46ca177

Yup, looks like it. Updates there should be mirrored here...

@PeterDaveHello PeterDaveHello mentioned this pull request Oct 31, 2017
@PeterDaveHello

Copy link
Copy Markdown
Member Author

Thanks guys, I also got the error locally, GPG keys updated in #564!

@SimenB

SimenB commented Nov 1, 2017

Copy link
Copy Markdown
Member

Not sure why the bot is not green...
image

@PeterDaveHello

Copy link
Copy Markdown
Member Author

docker-library/official-images#3655

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants