Repository navigation
Update the baseimage to debian:stretch-slim for node:slim image #821
Description
Activity
I got a recommendation of adding
Dockerfiletemplate in root directory by @PeterDaveHello. But in this case, I need to change the content ofDockerfile-slim.templateto accommodate the changes needed for the stretch release.We have 2 ways of doing this:
- Create
Dockerfile-slim-stretch.templateand mantain the changes for stretch-slim release - Modify the content to
Dockerfile-slim.templatefile which will enforce everyone to start using stretch as baseimage(one way it will make sure every damn image will work properly on all the arch)
So I need @PeterDaveHello and your team's opinion here to make the changes.
- Create
/cc @nodejs/docker
This would be wonderful. I have a requirement to be using Stretch for my base images for the security fixes, etc, and a requirement for slim to conserve space.
@mkumatag I would think Option 2 is better. Stretch is considered stable now.
Is there an eta on when this issue might be addressed?
@kbirger I already have a working PR ready, I'm just waiting for nodejs team to merge it.
Reacted by Kirill BirgerTo minimize disruption I created an alternate PR that gives users the choice between jessie or stretch for the slim variant.
I don't think we should switch the
slimvariant without also changing the default variant.Is there an update on this please?
The Docker Official Images build for Node is currently broken on ARM64.
We've changed default & slim variant to Stretch in the base image, and applied to the latest v11 release, would migrate v6, v8 & v10 to Stretch in future.
@lag-linaro I think we have ARM64 builds for these tags:
Tags: 8.12.0-alpine, 8.12-alpine, 8-alpine, carbon-alpine
Tags: 8.12.0-stretch, 8.12-stretch, 8-stretch, carbon-stretch
Tags: 6.14.4-stretch, 6.14-stretch, 6-stretch, boron-stretch
Tags: 11.0.0-alpine, 11.0-alpine, 11-alpine, alpine
Tags: 11.0.0-slim, 11.0-slim, 11-slim, slim
Tags: 11.0.0-stretch, 11.0-stretch, 11-stretch, stretch, 11.0.0, 11.0, 11, latest
Tags: 10.13.0-alpine, 10.13-alpine, 10-alpine, dubnium-alpine
Tags: 10.13.0-stretch, 10.13-stretch, 10-stretch, dubnium-stretchRef: https://github.com/docker-library/official-images/blob/master/library/node
@PeterDaveHello the trouble is, we have a dependency for Ghost:
https://github.com/docker-library/ghost/blob/master/2/debian/Dockerfile
Will the default 8-slim repo be moved to 8-stretch?
Another reference/request: TryGhost/docker-library-ghost#157 (comment)
It would be good if you could move all of your default images to Stretch.
Jessie is no longer receiving updates.
Jessie has LTS support until June 30, 2020, from the last discussion, we may transfer to Stretch about 1 month later.
cc @chorrell
Maybe we need a
slim-stretchvariant for 8.x.x and 10.x.x for the Ghost image to use?Reacted by Kirill Birgermaybe
But...I’m not sure it’s worth the effort. I’d rather just switch the slim variant for the next v8.x.x release
maybe open an issue for more formal discussion?
I don't understand - has there been any movement on this issue or not?
No, we haven't made any decision yet.
Ping @nodejs/docker for suggestions ;)
I think at this point we should just start switching over to stretch when we update each v10 and v8 image. The required changes are already in the repo. I think we can proabbly skip v6 since it will be gone soon and I don't see it being updated in the near future (but I could be wrong).
This would technically be a breaking change, but given the current situation, things are broken already. In the future we should create
stretch-slimvariant to set the groundwork for the next Debian release.That's what I tried to do with #850
Absolutely. I am very busy until end of week but I should have more time to dedicate to this next week.
Something is wrong with the build. It can't fetch any of the keys
See https://bugs.debian.org/913614 and the linked PRs/commits on docker-library/busybox#55.
Closing as stretch is now the default, and we provide a
jessieandjessie-slimoptions for those who need it.
Now security patches are limited to certain architectures for jessie release.
Refer following links for more information:
https://lists.debian.org/debian-security-announce/2018/msg00132.html
debuerreotype/docker-debian-artifacts#44 (comment)
vicamo/docker_buildpack-deps#33
Because of the above reason, we'll have to move to the next release of debian to build it on all different archs and works fine.