Repository navigation
Addition of MikeMcC399 to team #2448
Description
I'm fine with adding to the team, but I think he needs to be invited to the org first before being added to the team. I think that needs to go through nodejs/admin.
Originally posted by @nschonni in #2442
I'm happy to be considered for addition to the team and look forward to continuing to contribute here!
I checked nodejs/admin where it says:
GitHub users are added as members to our GitHub Organization when they are added to any Working Group or team. Organization Owners should add new members to the organization when requested by a Working Group or team.
so perhaps the team could just try adding me (https://github.com/MikeMcC399)?
Activity
nschonni commentedon Apr 10, 2026
Doesn't look like I can
MikeMcC399 commentedon Apr 10, 2026
Thanks for trying!
https://github.com/nodejs/admin/blob/main/GITHUB_ORG_MANAGEMENT_POLICY.md#teams is probably more the relevant section, although I wasn't sure quite how to interpret it, as this repo no longer has a Working Group, but it does have a governance document.
Should I just make a request myself to https://github.com/nodejs/admin/issues or would it be better if a sponsor, for example @sxa, did that on my behalf?MikeMcC399 commentedon Apr 10, 2026
https://docs.github.com/en/organizations/organizing-members-into-teams/adding-organization-members-to-a-team
So this can only be done by an organization owner, and it looks like that does need to go through https://github.com/nodejs/admin/issues
aduh95 commentedon Apr 13, 2026
IIUC you need to open a PR adding yourself to the README, once that's ready to land, you can be added to the team
docker-node/GOVERNANCE.md
Lines 81 to 89 in a15e208
sxa commentedon Apr 13, 2026
@aduh95 At the moment the collaborators list (as opposed to maintainers) for this repository is exclusively held within the docker team. The README states:
I'm personally ok with leaving that as-is and updating the documentation to have that exclusively in the docker team, or I guess we could duplicate the team contents into the readme (which I guess would have the advantage of making it more visible, since people with no access can see it)
I don't mind on the approach too much (bear in mind this team has just been dechartered as a working group, so we're really just seeing some process teething troubles here) Either way it will still need someone to add him into the top level org (requested in admin issue 1056 listed above) before the access can be granted.
aduh95 commentedon Apr 13, 2026
If the Docker WG have been dechartered, the documentation should be updated to reflect that, and
GOVERNANCE.mdmaybe deletedsxa commentedon Apr 13, 2026
The documentation was partially updated in https://github.com/nodejs/docker-node/pull/2383/changes for the decharter but that didn't include the GOVERNANCE.md updates (which are - as they were before - inconsistent). While I'm happy to push through whichever of the two options above are desired if there's a strong opinion either way I am also conscious of the fact that it would be good if we could get Mike added for now and then update the documentation appropriately after we decide that. I was added into the group without PRing myself into the readme, but that was simpler as I was already part of the org. At the moment the docs are inconsistent and whether we have a PR or this issue I think we should be good to add him for now, especially given the willingness to contribute things in relation to Node.js 26. At the moment it's not possible for him to create a PR as the list does not exist (unless he creates an effectively empty PR for approval purposes)
Let me know what you think or if we need to get the process formally changed first before he can be added.
aduh95 commentedon Apr 13, 2026
We need to update the docs to clarify what the process is – I don't really have an opinion what the process should be, I suppose it makes sense to have some gate keeping given how many folks would be affected by changing Docker images.
MikeMcC399 commentedon Apr 13, 2026
nschonni commentedon Apr 13, 2026
FYI, this was when we onboarded the Docker Hub people nodejs/admin#633. I'm not sure it's unique to a WG/team, but I think this must be the case for other non-WG teams in Node, since GitHub requires membership in the org (or the add to be done by an org-admin for non-org members)
MikeMcC399 commentedon Apr 14, 2026
That proposal has been picked up and submitted as PR #2455. This would provide a basis for a subsequent PR to add me to a then non-empty list of Collaborators.
MikeMcC399 commentedon Apr 16, 2026
The README Collaborators section is now populated with existing Collaborators.
MikeMcC399 commentedon Apr 16, 2026
This is not my reading of the GOVERNANCE document, which says:
There is no description in the document which allows for self-nomination. I hope that @sxa will pick up the action to open a corresponding PR to make this proposal, now he has pushed through the prerequisite publication of current Collaborators that I could be added to.
Edit: officially the nomination has to come from a maintainer, and @sxa is on the list of Collaborators only, so we'll have to see what happens here.
MikeMcC399 commentedon Apr 20, 2026
This issue is resolved and I am now listed under:
Collaborators
Special thanks to @nschonni & @sxa for their perseverance & support!