chore: set up vite+ - #1121
chore: set up vite+#1121TheAlexLichter wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ce126d1 to
eecbd4e
Compare
eecbd4e to
6769278
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1121 +/- ##
==========================================
+ Coverage 92.64% 92.72% +0.08%
==========================================
Files 244 245 +1
Lines 23114 23390 +276
Branches 2263 2263
==========================================
+ Hits 21413 21689 +276
Misses 1692 1692
Partials 9 9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
| File | Main | PR | Change |
|---|---|---|---|
orama-db.json |
9.54 MB | 9.54 MB | -141.00 B (-0.0%) |
Performance estimate (single CI run)
- Generation time: 47.5% slower (4.99 s → 7.36 s)
- Peak memory: 3.5% higher (1.84 GB → 1.90 GB)
web Generator
Performance estimate (single CI run)
- Generation time: 32.4% faster (64.65 s → 43.72 s)
- Peak memory: 20.7% higher (3.33 GB → 4.02 GB)
ovflowd
left a comment
There was a problem hiding this comment.
SGTM! Although, @TheAlexLichter the PR needs a rebase!
6769278 to
534227d
Compare
MattIPv4
left a comment
There was a problem hiding this comment.
My initial reaction to this is: why?
Why do we need to keep switching tooling every month to chase the new hotness? Why can't we stick with stable and time-proven tooling used by the industry writ large? And why do we keep introducing tooling that is different from our other projects?
I don't mean to come across as overly negative and I'm sure there are some performance gains from this, but this just strikes me as an unnecessary change that creates yet more mental overhead working with this project alongside our others.
And, honestly, it feels weird that it is folks from Vite+ themselves opening this PR to push their new tooling upon us.
Until we've got clear consensus on this value add here and alignment, I'm going to block this for now.
|
Hey @MattIPv4 👋 before jumping into your points, some additional context in the main PR.
IMO @bmuenzenmeyer summarized it nicely in this comment to be a bound experiment with intent rather than "yet another change": There are benefits in terms of number of packages, convenience, and speed (all while keeping things interoperable).
I, in no way, want to "push tooling upon you". This came up as a discussion first and sometimes showing is the easiest. I made these (and previous) PRs being aware that they could've been closed with a "no thank you". Sorry if it came across that way! |
|
Ah, I had missed that original PR and the context there, thanks. The review request on this PR was the first I had heard about any of this change. Again, don't want to be perpetually negative and I'm not against an experiment, and agree that of all the repos we own, this is probably the best to do it in. Though, I'm not sure this repo alone is really representative of the scope/size of our projects and I'm not sure would be enough for me to then agree we should adopt this tooling everywhere else. The gains outlined in the original PR were a ~2s saving and ~100 transitive dependencies. I personally am not sure I see that as super strong reason to chase the latest tooling rather than sticking with what we know is widely adopted and stable? Has any analysis/experimentation been done on our other projects, to indicate we might see more substantial gains in those, that'd then make this a worthwhile change to our tooling consistent across all our projects? I'd quite like to see a case for this being a value add as a whole before we land changes. |
Description
Only take a look at the latest commit. Stacked on #1120 (cant stack across PRs)
This PR moves from Oxlint and Oxfmt to Vite+ as a PoC. I know this will need some discussion around it but happy to chat 😋
Validation
Run all commands and see CI
Related Issues
Check List
node --run testand all tests passed.node --run format:check&node --run lint.