You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Agenda subject to this discussion. I think we should start with AsyncWrap since we missed it last time. @trevnorris@AndreasMadsen can you present status and next actions and lead a discussion for 10-15 minutes?
I'm working on something related to the Inspector stuff, will share soon.
@trevnorris should do the status update this time. I haven't been following the EP that closely, since the initial discussion was mostly reserved to CTC members. Besides the EP, the only thing that is new is:
uid is now a double
backport to 4.x
On future work that is discussion worth, I think it is mostly about getting handle context bugs fixed. #29 contains an overview of that. The status is (my opinions)
Microtask: difficult, but @ofrobots@jeisinger are optimistic about getting visibility from v8.
timers: should be relatively easy
addon modules integration: very difficult, at least without major breaking changes to how MakeCallback work.
@nodejs/diagnostics If anyone from the diagnostics group could provide some guidance on getting debugging/inspector support back into pl/v8 it would be much appreciated!
@jmealo: At this point, v8_inspector is the best bet for implementing debugging for V8; the older JSON based protocol has been deprecated for ~2 years now. From skimming the issue it seems like plv8 might be on V8 ~4.3 which would be unfortunately too old (you need atleast V8 5.0+ for v8_inspector to work).
To use v8_inspector in your project, here's a rough outline of what you will have to do:
Get v8_inspector from https://github.com/pavelfeldman/v8_inspector. We are keeping this repo as a convenient location for integration with Node.js. You can pick this code up directly from upstream Chromium too if you prefer. Note that at some point in the near-ish future this code will be merged directly into V8 and you won't have to pick it up externally.
A websockets implementation that would serve your debugger endpoint. You should look at src/inspector_agent.cc in Node.js as an example to see how this is wired up.
@ofrobots Thanks for the reply. The master branch is at 5.1.281.14. I haven't coded any serious C++ but I can take a look at it. I'm trying to get an implementation plan and do the footwork at the very least; so, this was very helpful.
Activity
joshgav commentedon Jun 23, 2016
Agenda subject to this discussion. I think we should start with AsyncWrap since we missed it last time. @trevnorris @AndreasMadsen can you present status and next actions and lead a discussion for 10-15 minutes?
I'm working on something related to the Inspector stuff, will share soon.
AndreasMadsen commentedon Jun 23, 2016
@trevnorris should do the status update this time. I haven't been following the EP that closely, since the initial discussion was mostly reserved to CTC members. Besides the EP, the only thing that is new is:
On future work that is discussion worth, I think it is mostly about getting handle context bugs fixed. #29 contains an overview of that. The status is (my opinions)
MakeCallbackwork.ofrobots commentedon Jun 23, 2016
I am away during the week of July 4, so I won't be able to make it.
joshgav commentedon Jun 23, 2016
@ofrobots - good point. Would you be able to attend on 7/13? Would others also prefer to postpone a week?
I'm +1 :)
MylesBorins commentedon Jun 23, 2016
I'm +1 on postponing a week
pmuellr commentedon Jun 23, 2016
Makes sense, w/ July 4th holiday
[-]Diagnostics WG Meeting - 2016-07-06[/-][+]Diagnostics WG Meeting - 2016-07-13[/+]joshgav commentedon Jun 24, 2016
Great, July 13 it is. Thanks!
joshgav commentedon Jul 11, 2016
@nodejs/diagnostics: reminder: meeting is this Wednesday July 13 at 12pm Pacific
@ofrobots @matthewloring - can you discuss the trace system? #53
@pavelfeldman - can you discuss progress on inspector integration? #52
@trevnorris - do you want to discuss AsyncWrap? /cc @bnoordhuis
I'd like to briefly discuss potential goals of nodejs/node#7393.
matthewloring commentedon Jul 12, 2016
We'll be there to discuss the tracing controller.
trevnorris commentedon Jul 12, 2016
@joshgav Not sure I have anything to discuss, but I'll be happy to take any questions.
AndreasMadsen commentedon Jul 12, 2016
@trevnorris I think this will be a good opportunity to get an update on the v8 microtask hooks and for you to explain the
MakeCallbacksolution.rvagg commentedon Jul 12, 2016
@Fishrock123 has an update about the microtask hooks .. not great news afaik
Jeff-Lewis commentedon Jul 12, 2016
I'm not sure if this means anything but v8 ticket 4643 MicrotaskQueue lacking introspection APIs was just assigned last night.
jmealo commentedon Aug 5, 2016
@nodejs/diagnostics If anyone from the diagnostics group could provide some guidance on getting debugging/inspector support back into pl/v8 it would be much appreciated!
plv8/plv8#131
ofrobots commentedon Aug 5, 2016
@jmealo: At this point, v8_inspector is the best bet for implementing debugging for V8; the older JSON based protocol has been deprecated for ~2 years now. From skimming the issue it seems like plv8 might be on V8 ~4.3 which would be unfortunately too old (you need atleast V8 5.0+ for v8_inspector to work).
To use v8_inspector in your project, here's a rough outline of what you will have to do:
src/inspector_agent.ccin Node.js as an example to see how this is wired up.jmealo commentedon Aug 5, 2016
@ofrobots Thanks for the reply. The master branch is at 5.1.281.14. I haven't coded any serious C++ but I can take a look at it. I'm trying to get an implementation plan and do the footwork at the very least; so, this was very helpful.
joshgav commentedon Sep 13, 2016
Would be great if I could get a couple LGTMs on the notes from this meeting. Thanks!