Skip to content

Lines with long URLs #24

Closed
Closed
Lines with long URLs#24

Description

@vsemozhetbyt
vsemozhetbyt
opened on Nov 18, 2017

Should we alleviate the 72 characters rule for lines with long URLs?

Example: nodejs/node#17107

Activity

  1. Tiriel commented on Nov 18, 2017

    @Tiriel
    Tiriel
    on Nov 18, 2017

    Well, AFAIC I'd say yes, it does seem logical otherwise the link will be broken, but I think it should first be discussed as meta in core, or wherever the contribution guides are discussed.

    I don't think that's quite up to us to decide to change the validation rules on our own.

  2. vsemozhetbyt commented on Nov 18, 2017

    @vsemozhetbyt
    vsemozhetbyt
    on Nov 18, 2017
    Author

    Core issue: nodejs/node#17116

  3. vsemozhetbyt
    added a commit that references this issue on Apr 22, 2018

    meta: document commit msg exception for long URLs

    2060787

  4. vsemozhetbyt commented on Apr 22, 2018

    @vsemozhetbyt
    vsemozhetbyt
    on Apr 22, 2018
    Author

    @Tiriel Exception approved and landed: nodejs/node#20207

  5. jasnell
    added a commit that references this issue on Apr 23, 2018

    meta: document commit msg exception for long URLs

    d591a59
  6. joyeecheung
    closed this as completedin #30on Nov 2, 2018
  7. joyeecheung
    added a commit that references this issue on Nov 2, 2018

    rules: skip line-length rule for URLs and quoted lines (#30)

    029fc30
  8. richardlau
    added a commit that references this issue on Dec 15, 2018

    rules: skip line-length rule for URLs and quoted lines (nodejs#30)

    5ef341d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions