Should nodejs/node#63869 (--experimental-strip-private-modules) land? - #1900
Open
github-actions[bot] wants to merge 6 commits into
Open
github-actions[bot] wants to merge 6 commits into
github-actions[bot] wants to merge 6 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node.js refuses to strip types from TypeScript files under
node_modulesand throws
ERR_UNSUPPORTED_NODE_MODULES_TYPE_STRIPPING. This keepsuncompiled TypeScript from becoming the entry point of packages published
to a registry.
nodejs/node#63869 adds
--experimental-strip-private-modules. With the flag, a TypeScript file undernode_modulescan be type stripped only if every package enclosing it in thenode_moduleschain has"private": truein its rootpackage.json. Nestedpackage.jsonfiles are ignored, and a non-private package anywhere in thechain (for example, a published package that bundles a private one) refuses
stripping. npm-compatible clients refuse to publish a
"private": truepackage. The intended use case is workspace packages that are copied rather
than symlinked into
node_modules, such aspnpm deployoutput, Dockerbuild contexts and vendored code.
If the first option wins, the request for changes is dismissed and the pull
request lands once it has passed CI. If the second option wins, the pull
request is closed.
Vote instructions:
To close the vote, at least 3 secret holder(s)1 must run the following command:
git node vote https://github.com/nodejs/TSC/pull/1900 --decrypt-key-part --post-comment/cc @nodejs/tsc
Current estimated participation: 22.22%
Footnotes
secret holders are folks who have access to the private key associated with a public key on hkps://keys.openpgp.org that references an email address listed on the TSC voting member list at the time of the opening of the vote. ↩