Repository navigation
doc: add process for adding new releasers - #321
Merged
Merged
Conversation
MylesBorins
force-pushed
the
adding-new-releasers
branch
from
April 5, 2018 20:49
abe35e7 to
74adbb6
Compare
gibfahn
reviewed
Apr 6, 2018
| When being officially added to the Releasers group the following must happen: | ||
|
|
||
| * Added to Releasers team in the Node.js org | ||
| * Jenkins release access needs to be given |
Member
There was a problem hiding this comment.
Adding them to the Releasers group gives them the access automatically. Maybe change to:
* Added to Releasers team in the Node.js org (grants ci-release access)|
|
||
| * Added to Releasers team in the Node.js org | ||
| * Jenkins release access needs to be given | ||
| * SSH keys need to be added to dist machines |
Member
There was a problem hiding this comment.
- SSH keys need to be added to the dist user on the
wwwmachine.
| * Added to Releasers team in the Node.js org | ||
| * Jenkins release access needs to be given | ||
| * SSH keys need to be added to dist machines | ||
| * GPG keys need to be added to the Secrets repo |
Member
There was a problem hiding this comment.
I don't think we give people access to machines on joining the Release group (cc/ @nodejs/build)
| * Jenkins release access needs to be given | ||
| * SSH keys need to be added to dist machines | ||
| * GPG keys need to be added to the Secrets repo | ||
| * GPG keys need to be added to README.md |
Member
There was a problem hiding this comment.
to the nodejs/node [README.md](https://github.com/nodejs/node/#release-team)| * SSH keys need to be added to dist machines | ||
| * GPG keys need to be added to the Secrets repo | ||
| * GPG keys need to be added to README.md | ||
|
|
Member
There was a problem hiding this comment.
I think we should add something like:
* Raise an issue in [nodejs/docker-node](https://github.com/nodejs/docker-node/) to note that the gpg keys will need to be updated.See for example nodejs/docker-node#564 when I was added.
MylesBorins
force-pushed
the
adding-new-releasers
branch
from
May 21, 2018 16:05
74adbb6 to
67d7660
Compare
Contributor
Author
|
Hey @nodejs/release @nodejs/tsc can people please take a look We have two outstanding release nominations that I would like to onboard, next week at collab summit seems like a great time to do it. |
jasnell
approved these changes
May 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Formalizing process around adding releasers as we have some folks nominated