Skip to content

fix(svg): quote true-valued XML attributes - #392

Open
woahwhattheheck wants to merge 3 commits into
nodegui:masterfrom
woahwhattheheck:sol56/nodegui31-svg-boolean-20261005
Open

woahwhattheheck wants to merge 3 commits into
nodegui:masterfrom
woahwhattheheck:sol56/nodegui31-svg-boolean-20261005

Conversation

@woahwhattheheck

@woahwhattheheck woahwhattheheck commented Oct 8, 2026 •

Copy link
Copy Markdown

Refs #31 — continuation of @bpc-oss's open PR #390 at head 877fa355. Verification: patch applies exactly to the pinned preimage at the stated head; postimage blob computed and pinned. No runtime/build/test execution was performed.


IssueHunt Summary

Referenced issues

This pull request has been submitted to:


bpc-oss and others added 2 commits June 27, 2026 17:50
Continuation of bpc-oss's open PR nodegui#390 at head 877fa35: the serializer emits `attr="true"` instead of a bare boolean attribute.
@woahwhattheheck

Copy link
Copy Markdown
Author

Current original-author head is d26defe45c83d3acbc34f76ec35b3fa04be6e875. This follow-up preserves explicit SVG/XML boolean values in both directions: true stays quoted, and false now serializes as attribute="false" instead of disappearing and falling back to a renderer default. A focused acceptance assertion covers both forms; a bounded serializer probe passed 3/3 (true, false, null omission). The Qt/qode harness and broad build were not run in this publication seat.

The existing /claim #31 remains active. I request maintainer review and, if this contribution is accepted, the applicable allocation from the publicly funded $20 IssueHunt pool plus payout instructions. This is not an assertion of assignment, acceptance, award, settlement, or receipt. Prior contribution authorship remains preserved.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants