Repository navigation
Return an ID token on refresh - #32
Merged
Merged
Conversation
This intends to fix nodeSolidServer#31. As part of the refresh grant, the ID token is now sent along with the access token.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This intends to fix #31.
As part of the refresh grant, the ID token is now sent along with the access token.
Note that not being familiar with the test setup, and pre-existing tests not being present for the refresh grant, I did not add test coverage. More generally, I couldn't test on a local deployment, because
@inrupt/generate-oidc-token, which makes it possible to get a refresh token easily and test if this PR fixes the behaviour, prevents using self-signed certificates. Would it be possible to deploy this onhttps://solidcommunity.net:8443, as was deployed the previous staged change, to facilitate tests ?