Skip to content

Fix new branch faulty 403 - #1136

Merged
kjetilk merged 3 commits into
nodeSolidServer:fix/new-branch-faulty-403from
michielbdejong:fix-new-branch-faulty-403
Mar 11, 2019
Merged

Fix new branch faulty 403#1136
kjetilk merged 3 commits into
nodeSolidServer:fix/new-branch-faulty-403from
michielbdejong:fix-new-branch-faulty-403

Conversation

@michielbdejong

@michielbdejong michielbdejong commented Mar 11, 2019

Copy link
Copy Markdown
Member

No description provided.

@michielbdejong

michielbdejong commented Mar 11, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author
  • even if strictOrigin is set to false, cookies should not be trusted cross-origin; fixed this here
  • puzzled by the behaviour here, added a FIXME note -> resolved
  • added a test for bearer token auth with untrusted origin and strictOrigin=true (expects a 403)
  • added a test for bearer token auth with untrusted origin and strictOrigin=true (expects a 200)

@michielbdejong
michielbdejong requested a review from kjetilk March 11, 2019 18:59
kjetilk
kjetilk approved these changes Mar 11, 2019
View reviewed changes

@kjetilk kjetilk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we can do a new review round from the upstream issue.

@kjetilk
kjetilk merged commit 2d6e331 into nodeSolidServer:fix/new-branch-faulty-403 Mar 11, 2019
@michielbdejong
michielbdejong deleted the fix-new-branch-faulty-403 branch March 12, 2019 19:05
@michielbdejong michielbdejong mentioned this pull request Mar 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kjetilk kjetilk kjetilk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@michielbdejong @kjetilk