Repository navigation
Moving the creation of ACLChechker into a factory method - #1075
Merged
Merged
Conversation
megoth
requested review from
RubenVerborgh,
dmitrizagidulin,
kjetilk and
rubensworks
January 29, 2019 15:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a solution that is used in both https://github.com/solid/node-solid-server/tree/feature/quota-ui and https://github.com/solid/node-solid-server/tree/bug/root-index-special-handling.
I want to suggest this way of changing the code, to encourage reuse of code (as I'm planning to do in aforementioned branches). But this might not be the most intuitive way to create the ACLChecker class (it's simply a very pragmatic move of code from my part), so am open to suggestions on other ways of doing this ^_^