Skip to content

Login not asking for credentials after a logout #695

Closed

Description

@PulsarFox

I'm currently on Ubuntu 17.10, with node-solid-server v4.0.10
My index.html is hosted on live server extension on Visual Studio Code and it has my js file in it.

In my script I login with OIDCWebclient and I reproduced the exact steps for login as written here : https://hackmd.io/onfGBqczTzClCd2DUKViEg#

Login works fine, the first time it asks me the credentials and redirects me to my html page.

Then I logout with auth.logout() but when I want to log in again it does not asks me my credentials but log me in directly. And I want to be able to select another account.

I tried to visit the /logout endpoint with window.location then hit backwards but nothing changed.
Even if I don't hit backwards or open it in another tab nothing changes, the log in does not ask me for credentials.

EDIT : i've tried with RawGit, it does the same thing.
The only way i've managed to log in again is by stopping the server and run it again

Activity

  1. dmitrizagidulin commented on Jun 1, 2018

    @dmitrizagidulin
    Contributor

    Thanks @PulsarFox! I'm working on a fix now, will update this issue as soon as it's ready.

  2. PulsarFox commented on Jun 6, 2018

    @PulsarFox
    Author

    Well fixed, the logout seems to need the credentials to logout (yea it's obvious when I think of it)
    so in order to disconnect I did a Get request with fetch function given with OIDC on /logout endpoint

    I didn't think of it before but yea if the logout was accessible everywhere, everyone could log you off heh...

    EDIT : Fake alert, it was nodemon restarting the server and with a restart it works.
    Even with fetch with credentials, a get request to the endpoint https://mypod.localhost:8443/logout does not work

  3. RubenVerborgh commented on Jul 19, 2018

    @RubenVerborgh
    Contributor

    Following up in #675.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions