If server has favico.ico at usual place it should be used rather than the solid icon. #486

Activity

1. timbl commented on Jan 15, 2017

   

   timbl

   on Jan 15, 2017

   ContributorAuthor

   More actions

   (I also notice the default provided looks smaller than icons for other sites)
2. timbl

   changed the title [-]If server has favico.ico at usual place it should NOT be overwritten[/-] [+]If server has favico.ico at usual place it should be used rather than the solid icon.[/+] on Jan 15, 2017
3. dmitrizagidulin commented on Jan 20, 2017

   

   dmitrizagidulin

   on Jan 20, 2017

   Contributor

   More actions

   After investigation, I do not see a good way to detect a favicon.ico request, then check if an icon exists for that account, and if not invoke the serve-favicon npm lib.

   So I think the best way to fix this issue is to remove the serve-favicon npm lib, and to create a default favicon.ico and the corresponding favicon.ico.acl during account creation (along with the other default folders & files). And then the user can delete it or upload a different one, as they like.
4. dmitrizagidulin

   added a commit that references this issue on Feb 9, 2017

   Remove 'serve-favicon' package, it's now initialized on account creation

   ...

   108e6db
5. dmitrizagidulin

   added a commit that references this issue on Mar 8, 2017

   Remove 'serve-favicon' package, it's now initialized on account creation

   ...

   ca18e39
6. dmitrizagidulin commented on Mar 13, 2017

   

   dmitrizagidulin

   on Mar 13, 2017

   Contributor

   More actions

   Fixed as of PR #492, closing.
7. dmitrizagidulin

   closed this as completedon Mar 13, 2017