Skip to content

docker documentation for config files is no longer valid #1450

Open

Description

@alastair

The docker installation instructions (https://github.com/solid/node-solid-server#use-docker) have a step:

docker cp solid:/usr/src/app/config.json .

However by default this file doesn't exist, I get an error:

Error: No such container:path: solid:/usr/src/app/config.json

I was able to successfully create a config file using solid init and then copy it

perhaps these instructions need to be updated to cover some recent changes to the docker setup?

Activity

  1. bourgeoa commented on Jul 23, 2020

    @bourgeoa
    Member

    Thanks for raising the issue. The problem comes from the introduction of a solid docker image, which uses a different home folder (opt/solid/) than the original dockerfile (usr/src/app/).

    Something should be updated.
    @angelo-v what do you think : change the documentation or align docker image and dockerfile ?

    • align docker image and dockerfile has a big draw back : both are used in production
    • then change the documentation, may be the only feasible solution.
  2. angelo-v commented on Jul 28, 2020

    @angelo-v
    Contributor

    We should clarify in the documentation, that the docker image is configured via environment variables (as it is common with docker). The config.json should not be used at all

  3. alastair commented on Jul 29, 2020

    @alastair
    Author

    Thanks for the comment. This helpfully answers my questions in #1453 too

  4. TallTed commented on Nov 9, 2020

    @TallTed
    Member

    @angelo-v wrote:

    The config.json should not be used at all

    That's in direct contradiction to the current docs! (scroll up one paragraph from the header to which this links)

    Configuring Solid via the config file can be a concise and convenient method and is the generally recommended approach.

    (Quite likely, this should be combined with #1453.)

  5. angelo-v commented on Nov 9, 2020

    @angelo-v
    Contributor

    You are referring to a paragraph that is not about docker usage. My statement that you quote is about docker usage only.

  6. TallTed commented on Nov 12, 2020

    @TallTed
    Member

    @angelo-v -- Ah, sorry, my mis-read. :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions