Skip to content

Fix freeze on OS X with Firewall enabled - #4

Merged
xudafeng merged 1 commit into
node-modules:masterfrom
gaearon:master
Aug 1, 2016
Merged

xudafeng merged 1 commit into
node-modules:masterfrom
gaearon:master

Conversation

@gaearon

@gaearon gaearon commented Aug 1, 2016

Copy link
Copy Markdown
Collaborator

It appears that letting Node.js use localhost by default is much faster (a few seconds instead of a minute) than using external IP for determining whether the port is busy.

Fixes #3.

I tested this on OS X, Windows, and Linux.

It appears that letting Node.js use localhost by default is much faster (a few seconds instead of a minute) than using external IP for determining whether the port is busy.
Fixes node-modules#3.
@coveralls

coveralls commented Aug 1, 2016 •

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.9%) to 63.415% when pulling 33d00f2 on gaearon:master into 632dabf on xudafeng:master.

@xudafeng xudafeng closed this Aug 1, 2016
@xudafeng xudafeng reopened this Aug 1, 2016
@xudafeng
xudafeng merged commit e184c1b into node-modules:master Aug 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants