Skip to content

bug: constructor mutates it's argument (options) #101

Open
Open
bug: constructor mutates it's argument (options)#101

Description

@adrian-gierakowski
adrian-gierakowski
opened on Nov 19, 2021

for example here:

agentkeepalive/lib/agent.js

Lines 32 to 37 in 01e61e9

options = options || {};
options.keepAlive = options.keepAlive !== false;
// default is keep-alive and 15s free socket timeout
if (options.freeSocketTimeout === undefined) {
options.freeSocketTimeout = 15000;
}

If the options argument is defined it should be cloned before having it's props mutated.

I'm happy to submit a PR, just wanted to check that the author agrees with the suggestion

Activity

  1. adrian-gierakowski
    changed the title [-]constructor mutates it's argument (options)[/-] [+]bug: constructor mutates it's argument (options)[/+] on Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions