You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Add ways to filter (or hook) request/response objects #46
changed the title [-]Create method makes request object on RPC client, makes response object on RPC server[/-][+]Add ways to filter (or hook) request/response objects[/+]on Dec 2, 2016
It actually isn't done yet. We thought there should be 4 extension points i.e. (requests, response) × (client, server), but there currently are only two hooks (Client.make_request() and WsgiApp.make_response()).
In particular, response hook on client-side is necessary to extend transport layer. Because there's no extension point to urllib.request (that Client uses in the underlying) whereas server-side hooks can be replaced by WSGI middlewares. In fact, we are okay even if there are no server-side hooks.
Activity
[-]Create method makes request object on RPC client, makes response object on RPC server[/-][+]Add ways to filter (or hook) request/response objects[/+]kanghyojun commentedon Dec 16, 2016
DONE
dahlia commentedon Jun 20, 2017
It actually isn't done yet. We thought there should be 4 extension points i.e. (requests, response) × (client, server), but there currently are only two hooks (
Client.make_request()andWsgiApp.make_response()).In particular, response hook on client-side is necessary to extend transport layer. Because there's no extension point to
urllib.request(thatClientuses in the underlying) whereas server-side hooks can be replaced by WSGI middlewares. In fact, we are okay even if there are no server-side hooks.