Skip to content

Compatibility issue with Python 3.7 #116

Closed
Closed
Compatibility issue with Python 3.7#116

Description

@AiOO
AiOO
opened on Feb 28, 2019

Since the typing module in Python 3.7 doesn't have TupleMeta class, AttributeError occurs by below line . To support Python 3.7 it should be fixed.

nirum-python/nirum/deserialize.py

Line 203 in 1721295

elif type(cls) is typing.TupleMeta:

relative commit: python/cpython@d911e40#diff-015978a768b517a38abbc0ecdea87f5a

Activity

  1. kanghyojun commented on Feb 28, 2019

    @kanghyojun
    kanghyojun
    on Feb 28, 2019
    Member

    However, with the higher version of Nirum compiler, deserialize_meta dosen't used anymore. So we should fix compiler code https://github.com/nirum-lang/nirum/blob/0.5-maintenance/src/Nirum/Targets/Python.hs

  2. kanghyojun commented on Feb 28, 2019

    @kanghyojun
    kanghyojun
    on Feb 28, 2019
    Member

    Since nirum-lang/nirum#278 was merged, deserialized_meta was deprecated and typing.TupleMeta wasn't used anymore. So I think that there are no bugs if you use the latest version of Nirum compiler. Thanks for your reporting :)

  3. kanghyojun
    closed this as completedon Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions