Repository navigation
A reload keeps the place it was on - #11
Merged
Merged
Conversation
A reload re-activates the session through the provider, which sends the browser back to the redirect URL without its fragment, so every reload landed on the home screen (#/). The library hands the old address back with the sessionRestore event; completeLogin now puts it back, same origin only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reloading on
#/p/dashboard/now.mdsent you back to the pod root.Why: with
restorePreviousSession, a reload re-activates the session by a silent round trip through the provider (prompt=none). The provider sends the browser back to the redirect URL, which has no fragment, since OIDC refuses one. So the hash route was lost. The Inrupt library saveslocation.hrefbefore the round trip and emitssessionRestorewith it, but nothing was listening.Change:
completeLoginlistens forEVENTS.SESSION_RESTOREDand callshistory.replaceStateback to that address before the first render.restoredAddressaccepts same-origin addresses only, because the value comes from localStorage. It has tests.No new button: a reload now does what you expected.
Manual test (test.nicolasdb.eu): open a file in Places, reload, and you should stay on that file. Also check the first sign-in still lands on
#/.🤖 Generated with Claude Code