Repository navigation
Update reference docs for new types and read methods. - #189
Merged
Merged
Conversation
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The promised read_condition_value documentation is missing.
1 open finding
What changed in this PR
Updates reference documentation for renamed measurement reads and float waveform support.
Changes:
- Replaces
read_datawithread_measurement_value. - Documents float waveform, complex waveform, and spectrum types.
| File | Description |
|---|---|
docs/reference/using-measurement-data-services.md |
Updates measurement-reading examples. |
docs/reference/ni-data-store.md |
Adds supported float data types. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
dixonjoel
approved these changes
Oct 12, 2026
csjall
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Updates the reference docs to include these API changes:
read_datatoread_measurement_valueandread_condition_valueWhy should this Pull Request be merged?
To keep the documentation up to date.
What testing has been done?
PR readthedocs builds.